Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clients exactly #1

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add clients exactly #1

merged 3 commits into from
Oct 26, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Aug 30, 2023

Description

  • Migrate clients from the flexible-voting repo
  • There is a corresponding pr in the flexible-voting repo to remove what was migrated.
  • No alterations were made a follow up pr will clean up some of the comments and update the flexible-voting dep to match the flexible-voting repo without these client files.

@alexkeating
Copy link
Collaborator Author

alexkeating commented Aug 30, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/FlexVotingClient.sol Fixed Show resolved Hide resolved
src/ATokenFlexVoting.sol Dismissed Show resolved Hide resolved
src/FlexVotingClient.sol Fixed Show resolved Hide resolved
src/FlexVotingClient.sol Fixed Show resolved Hide resolved
src/ATokenFlexVoting.sol Dismissed Show resolved Hide resolved
src/CometFlexVoting.sol Dismissed Show resolved Hide resolved
src/CometFlexVoting.sol Dismissed Show resolved Hide resolved
src/FlexVotingClient.sol Fixed Show resolved Hide resolved
src/FlexVotingClient.sol Fixed Show resolved Hide resolved
@alexkeating alexkeating marked this pull request as ready for review August 31, 2023 01:50
@mds1
Copy link

mds1 commented Sep 1, 2023

No alterations were made a follow up pr will clean up some of the comments and update the flexible-voting dep to match the flexible-voting repo without these client files.

Agreed with not making alterations to code in this PR. As a result, for any of the above code scanning suggestions that we fix, that can be done in a follow up PR

.github/workflows/ci.yml Outdated Show resolved Hide resolved
coverage.sh Show resolved Hide resolved
coverage.sh Outdated Show resolved Hide resolved
coverage.sh Outdated Show resolved Hide resolved
script/Deploy.s.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating mentioned this pull request Sep 6, 2023
coverage.sh Outdated Show resolved Hide resolved
coverage.sh Outdated Show resolved Hide resolved
@apbendi apbendi force-pushed the feature/add-clients branch 2 times, most recently from 19a7348 to c532578 Compare October 26, 2023 20:47
alexkeating and others added 3 commits October 26, 2023 16:51
@github-actions
Copy link

Coverage after merging feature/add-clients into main will be

88.89%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ATokenFlexVoting.sol82.35%100%80%83.33%63, 74
   CometFlexVoting.sol100%100%100%100%

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@apbendi apbendi merged commit cd48bb5 into main Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants