-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aave naive approach #11
Conversation
90ac753
to
48dc573
Compare
eee963c
to
cdecbf1
Compare
4b48376
to
4786971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not reviewed the tests yet, but figured I left enought comments to submit those for now. Looks good and clean overall, nice work
Co-authored-by: Matt Solomon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my first pass @davidlaprade, nice work. Left some thoughts on the ongoing discussions.
Co-authored-by: Matt Solomon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @davidlaprade—nice job on this. Getting the test harness in place was obviously a pretty tedious lift, but you did a great job! Will be really helpful as we dive into the two other approaches.
RE #7
Rough usecase: