Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compound V3 client contract #46

Merged
merged 30 commits into from
May 26, 2023
Merged

Add Compound V3 client contract #46

merged 30 commits into from
May 26, 2023

Commits on Mar 29, 2023

  1. Install Comet (aka Compound v3)

    @davidlaprade
    davidlaprade committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    59cbe9b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Test initial setup/config

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0b42108 View commit details
    Browse the repository at this point in the history

  2. Test that we can supply + withdraw

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0f8863d View commit details
    Browse the repository at this point in the history

  3. Test that supplied gov earns yield and can be borrowed

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    aa7eea2 View commit details
    Browse the repository at this point in the history

  4. Expand yield claiming test

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7435540 View commit details
    Browse the repository at this point in the history

  5. Begin testing vote functionality

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    edc30df View commit details
    Browse the repository at this point in the history

  6. Abstract re-usable flex voting client behavior into separate contract

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    0d7277c View commit details
    Browse the repository at this point in the history

  7. Have CometFlexVoting use the FlexVotingClient

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    8eab9ee View commit details
    Browse the repository at this point in the history

  8. Checkpoint changes to principal balance

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    08a7316 View commit details
    Browse the repository at this point in the history

  9. Update comment

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    dc09ee9 View commit details
    Browse the repository at this point in the history

  10. Add some tests

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2fe4e57 View commit details
    Browse the repository at this point in the history

  11. Fix total deposit checkpointing in Comet

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4edcf50 View commit details
    Browse the repository at this point in the history

  12. Implement more tests, add testing TODOs

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    984a8d3 View commit details
    Browse the repository at this point in the history

  13. Use Comet fork so that updateBasePrincipal can be overridden

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f9307fe View commit details
    Browse the repository at this point in the history

  14. scopelint

    @davidlaprade
    davidlaprade committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2d2908c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Temporarily remove size check and formatting on CI 

    * we are way over the size limit for Comet now -- need to look into why

* scopelint doesn't give us the option to selectively ignore naming
conventions on specific lines; because we are overriding certain Comet
functions we don't have the option to change their names
    @davidlaprade
    davidlaprade committed May 16, 2023
    Configuration menu
    Copy the full SHA
    95ab0c5 View commit details
    Browse the repository at this point in the history

  2. Why are the tests failing?

    @davidlaprade
    davidlaprade committed May 16, 2023
    Configuration menu
    Copy the full SHA
    671d697 View commit details
    Browse the repository at this point in the history

  3. Expose MAINNET_RPC_URL

    @davidlaprade
    davidlaprade committed May 16, 2023
    Configuration menu
    Copy the full SHA
    39b0d8c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Matt Solomon <[email protected]>
    @davidlaprade @mds1
    davidlaprade and mds1 authored May 17, 2023
    Configuration menu
    Copy the full SHA
    abb876d View commit details
    Browse the repository at this point in the history

  2. Remove need for comments in struct instances

    @davidlaprade
    davidlaprade committed May 17, 2023
    Configuration menu
    Copy the full SHA
    306eee7 View commit details
    Browse the repository at this point in the history

  3. Re-enable formatting with just the forge formatter

    @davidlaprade
    davidlaprade committed May 17, 2023
    Configuration menu
    Copy the full SHA
    951fcdf View commit details
    Browse the repository at this point in the history

  4. Miscellaneous PR review changes

    @davidlaprade
    davidlaprade committed May 17, 2023
    Configuration menu
    Copy the full SHA
    82c2ba0 View commit details
    Browse the repository at this point in the history

  5. Flesh out natspec for FlexVotingClient

    @davidlaprade
    davidlaprade committed May 17, 2023
    Configuration menu
    Copy the full SHA
    375b73b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Fix natspec comment levels in FlexVotingClient

    @davidlaprade
    davidlaprade committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1ac8bc2 View commit details
    Browse the repository at this point in the history

  2. Miscellaneous test file revisions for PR review

    @davidlaprade
    davidlaprade committed May 18, 2023
    Configuration menu
    Copy the full SHA
    56bf3cf View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. More PR tweaks

    @davidlaprade
    davidlaprade committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3f1a7ae View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Add FlexVotingComet description

    @davidlaprade
    davidlaprade committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c3b2fe3 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Allow client contracts to customize the voting reason param

    @davidlaprade
    davidlaprade committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9228936 View commit details
    Browse the repository at this point in the history

  2. Remove TODOs 

    Ported over to #49
    @davidlaprade
    davidlaprade committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c51734f View commit details
    Browse the repository at this point in the history

  3. Update src/CometFlexVoting.sol 

    Co-authored-by: Matt Solomon <[email protected]>
    @davidlaprade @mds1
    davidlaprade and mds1 authored May 26, 2023
    Configuration menu
    Copy the full SHA
    c6cc147 View commit details
    Browse the repository at this point in the history