Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Improvements and Refactors to Test Suite #7

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Various Improvements and Refactors to Test Suite #7

merged 1 commit into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. Correct the registry domain separator and refactor test suite 

    * Test internal variable initialization in registry constructor tests
* Improvements to domain separator test
* Improvements to the RegisteryKeys tests
* Naming improvements to registerKeysOnBehalf tests
* Update test imports and remove duplicated import
* Refactor signature test helpers for test simplicity
* Simplify mock contract for ERC1271 signatures
* Remove redundant test and add missing ones for register on behalf
* Minor cleanup to increment nonce test
* Update the EIP712Domain separator to match the spec
* Simplify Announcer test names
* Use `vm.expectRevert("")` instead of `vm.expectRevert()`
    @apbendi
    apbendi committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5b2de7a View commit details
    Browse the repository at this point in the history