feat: increase test coverage #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
garyghayrat
reviewed
Apr 15, 2024
garyghayrat
reviewed
Apr 16, 2024
Co-authored-by: Gary Ghayrat <[email protected]>
* fix: use beforeall * fix: use beforeAll * fix: use beforeAll * fix: use beforeAll * fix: use beforeAll * fix: beforeAll * chore: remove logs * feat: large num of announcements to 100 for testing speed * chore: spelling * feat: biome for linting and formatting (#56) * feat: biome * chore: biome format * chore: biome no trailing comma * chore: format examples with biome * chore: format * feat: biome format * feat: biome lint script * feat: biome check * fix: lint errors * feat: remove lint since build already runs biome check * chore: format * feat: apply * chore: import sort * fix: use biome * feat: deterministic gen stealth meta address (#60) * fix: valid compressed key input type clarity * fix: comment and variable clarity * feat: get stealth meta address from keys * feat: is valid pub key * feat: is valid key tests * feat: gen keys from sig * chore: default export * chore: fix import * fix: test * feat: extract portions into own func for testing * feat: get stealth meta address from signature * feat: test * feat: example for gen stealth meta address from sig * chore: lint * fix: comment * feat: change get to generate (verbiage) * fix: generate verbiage * chore: clean * Update examples/generateDeterministicStealthMetaAddress/README.md Co-authored-by: Gary Ghayrat <[email protected]> * feat: send and receive test (#62) * feat: handle just passing the stealth meta-address directly * chore: format * chore: format * feat: send and receive test * chore: format * chore: comment * chore: comment * chore: clean * chore: clean * fix: just wait for the receipt --------- Co-authored-by: Gary Ghayrat <[email protected]> * fix: ci workflow for check * fix: dont apply with check * fix: check to end * chore: check --------- Co-authored-by: Gary Ghayrat <[email protected]> --------- Co-authored-by: Gary Ghayrat <[email protected]>
marcomariscal
added a commit
that referenced
this pull request
May 3, 2024
…#46) * feat: improve coverage * feat: coverage to .98 * package: update viem * feat: large num of announcements to 100 for testing speed * feat: biome for linting and formatting (#56) * feat: deterministic gen stealth meta address (#60) * fix: valid compressed key input type clarity * feat: get stealth meta address from keys * feat: is valid pub key * feat: is valid key tests * feat: gen keys from sig * feat: extract portions into own func for testing * feat: get stealth meta address from signature * feat: example for gen stealth meta address from sig * Update examples/generateDeterministicStealthMetaAddress/README.md * feat: send and receive test (#62) * feat: handle just passing the stealth meta-address directly * feat: send and receive test --------- Co-authored-by: Gary Ghayrat <[email protected]>
marcomariscal
added a commit
that referenced
this pull request
May 4, 2024
…#46) * feat: improve coverage * feat: coverage to .98 * package: update viem * feat: large num of announcements to 100 for testing speed * feat: biome for linting and formatting (#56) * feat: deterministic gen stealth meta address (#60) * fix: valid compressed key input type clarity * feat: get stealth meta address from keys * feat: is valid pub key * feat: is valid key tests * feat: gen keys from sig * feat: extract portions into own func for testing * feat: get stealth meta address from signature * feat: example for gen stealth meta address from sig * Update examples/generateDeterministicStealthMetaAddress/README.md * feat: send and receive test (#62) * feat: handle just passing the stealth meta-address directly * feat: send and receive test --------- Co-authored-by: Gary Ghayrat <[email protected]>
marcomariscal
added a commit
that referenced
this pull request
May 4, 2024
…#46) * feat: improve coverage * feat: coverage to .98 * package: update viem * feat: large num of announcements to 100 for testing speed * feat: biome for linting and formatting (#56) * feat: deterministic gen stealth meta address (#60) * fix: valid compressed key input type clarity * feat: get stealth meta address from keys * feat: is valid pub key * feat: is valid key tests * feat: gen keys from sig * feat: extract portions into own func for testing * feat: get stealth meta address from signature * feat: example for gen stealth meta address from sig * Update examples/generateDeterministicStealthMetaAddress/README.md * feat: send and receive test (#62) * feat: handle just passing the stealth meta-address directly * feat: send and receive test --------- Co-authored-by: Gary Ghayrat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves test coverage across the board.
the
fetchJsonfunc insetupTestEnvneeds more coverage, but still have yet to figure out how to mock the global fetch func in bun, and/or figure out another way. this is why i've increased the coverage threshold to only .8, but wanting to get this to 1.