Add a workaround for disc sprite appearing shadowed

Scotsguy · Aug 8, 2024 · 69f46df · 69f46df
1 parent fc40a66
commit 69f46df
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1 +1,2 @@
 - Fix a bug causing jukebox song to display incorrectly
+- Add a workaround for disc sprite appearing shadowed
diff --git a/common/src/main/java/com/github/scotsguy/nowplaying/gui/toast/NowPlayingToast.java b/common/src/main/java/com/github/scotsguy/nowplaying/gui/toast/NowPlayingToast.java
@@ -38,9 +38,12 @@ public NowPlayingToast(Component description, ItemStack itemStack) {
     @Override
     public @NotNull Visibility render(@NotNull GuiGraphics graphics, @NotNull ToastComponent toastComponent, long startTime) {
         float scale = Config.get().options.toastScale;
-        graphics.pose().pushPose();
-        graphics.pose().translate(160 * (1 - scale), 0.0F, 0.0F);
-        graphics.pose().scale(scale, scale, 0.0F);
+        // TODO figure out why graphics pose() causes disc sprite to appear shadowed
+        if (scale != 1.0F) {
+            graphics.pose().pushPose();
+            graphics.pose().translate(160 * (1 - scale), 0.0F, 0.0F);
+            graphics.pose().scale(scale, scale, 0.0F);
+        }
 
         Minecraft game = Minecraft.getInstance();
 
@@ -85,7 +88,7 @@ public NowPlayingToast(Component description, ItemStack itemStack) {
         // Draw icon
         graphics.renderFakeItem(itemStack, 9, (height / 2) - (16 / 2));
 
-        graphics.pose().popPose();
+        if (scale != 1.0F) graphics.pose().popPose();
         return startTime - this.startTime >= this.displayTime ? Visibility.HIDE : Visibility.SHOW;
     }