SFD-200: Persist diagram display #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't store the error state as it should be re-generated
|
I think this is fine. It would be nice to resolve the edge cases but I think that would take a bit of work. I've created SFD-208 to look into it. |
jantoun-scottlogic
approved these changes
Sep 9, 2024
|
Tested & Approved - SD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFD-200 Jira ticket
Description of Change
Restore the diagram state when navigating away from the site and returning.
Possibly one for @jantoun-scottlogic to review the approach, as it seemed simplest to just call
handleSubmit()if it was done previously, instead of having the diagram store state as well. There are some edge cases, where the form has been changed but not resubmitted before navigating away and it also does not restore which display tab was active when looking at the table.I also didn't need to update any tests to make this change but I wasn't sure whether to get into checking what the form storage service was called with and how the init process changes when existing state is found.
Checklist