Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change padding for instructor cards #148

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Change padding for instructor cards #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions frontend/src/components/InstructorDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const InstructorDetail = ({ name, showLoading }: Props) => {
// const coursesTaught = new Set(fces.map(({ courseID }) => courseID));

return (
<div className="m-auto space-y-4 p-6">
<Card>
<div>
<Link href={`/instructor/${name}`}>
Expand All @@ -50,7 +49,6 @@ const InstructorDetail = ({ name, showLoading }: Props) => {
<InstructorFCEDetail fces={fces} aggregationOptions={aggregationOptions} />
</div>
</Card>
</div>
);
};

Expand Down
10 changes: 9 additions & 1 deletion frontend/src/pages/instructor/[name].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,21 @@ import InstructorDetail from "../../components/InstructorDetail";
import Aggregate from "../../components/Aggregate";
import CourseFilter from "../../components/filters/CourseFilter";

const PaddedInstructorDetail = (name : string) =>{
return (
<div className="m-auto space-y-4 p-6">
<InstructorDetail name={name} showLoading={true} />
</div>
)
}

const InstructorPage: NextPage = () => {
const router = useRouter();
const name = router.query.name as string;

return (
<Page
content={<InstructorDetail name={name} showLoading={true} />}
content={PaddedInstructorDetail(name)}
sidebar={
<>
<Aggregate />
Expand Down
Loading