Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just a small .eslintrc change #369

Closed
wants to merge 1 commit into from
Closed

just a small .eslintrc change #369

wants to merge 1 commit into from

Conversation

cirex-web
Copy link
Contributor

@GhostOf0days
Copy link
Member

I thought about this, and I'm opposed to this change. I'm not sure where we will run into conflicts between Airbnb and recommended Prettier configs. In all honesty, Airbnb standards are better. In general, Airbnb engineers are very good at making TypeScript tools (such as https://github.com/airbnb/ts-migrate) and standards. I would consider Airbnb the gold standard for TypeScript and relevant code standards similar to how Google's C++ Style Guide is the gold standard for C++ code.

As for the errors to warnings, this would make sense if we didn't have a GitHub Action for linting and making sure we follow code standards, but we do, so it should be kept how it previously was. The reason is, when linting, warnings would not result in failure, so the GitHub Action could show a green checkmark on GitHub when a PR is made although it should fail tests. This issue is seen when installing npm packages in the process of running a GitHub Action. Warnings are ignored and could cause us to merge in packages that have security vulnerabilities or are deprecated (we currently take care of this through Dependabot scans to create automatic PRs).

@GhostOf0days GhostOf0days deleted the eslintrc-changes branch January 9, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants