Intel and Scouting System #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealMaxion
suggested changes
Sep 30, 2017
src/extends/room/intel.js
Outdated
| // Record room owner, level. | ||
| if (this.controller) { | ||
| if (this.controller.owner) { | ||
| roominfo[INTEL_OWNER] = this.controller.owner |
There was a problem hiding this comment.
shouldn't this be saving owner.username?
src/roles/spook.js
Outdated
| } | ||
|
|
||
| stompConstruction (creep) { | ||
| const construction = creep.pos.findClosestByRange(FIND_HOSTILE_CONSTRUCTION_SITES) |
There was a problem hiding this comment.
if we don't filter out construction sites in the same position as the creep then the creep can get stuck on sites that are instantly replaced
There was a problem hiding this comment.
I thought you couldn't place a construction site where a hostile creep was standing?
There was a problem hiding this comment.
I've had stomping creeps get stuck that way before at least.
TheRealMaxion
approved these changes
Sep 30, 2017
|
This Pull Request has been merged by GitConsensus. Vote Totals
Vote Breakdown
Vote Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives everything needed for #84 except the portal data. It resolves #85.
This provides two new systems-
Intel
The intel system has a few components-
New
Roomfunctions-Room.prototype.getIntel,Room.getIntel,Room.prototype.saveIntel,Room.getResourcesPositions,Room. requestIntel, andRoom. getScoutTarget. These functions are backed by a segment but use a memory buffer to reduce CPU usage when saving.Scouting targets are set automatically when calls to
getIntelfail to retrieve data or gets data that is too old. TheRoom.requestIntelfunction can be called to manually add a target.If no valid targets are available then
Room. getScoutTargetwill return a neighboring room. It will prioritize unseen rooms first (if it encounters multiple unseen rooms it picks the closest to the supplied creep's parent room), and then will prioritize the room that hasn't been updated recently.Scouting
A new creep role,
Spook, has been added. It does a few things-If it sees hostile construction sites in a room it steps on them.
If it sees an controller that isn't signed by the creep's player then the creep will sign it.
If it has nothing else to do it requests a new room target from
Room.getScoutTargetand then travels to that room.