Added dialog for permissions, cleaner permission handling.

.gitignore

@@ -1,8 +1,8 @@
 *.iml
 .gradle
-/local.properties
-/.idea/
+local.properties
+.idea
 .DS_Store
-/build
-/captures
+build
+captures
 .externalNativeBuild

app/build.gradle

@@ -1,9 +1,5 @@
 apply plugin: 'com.android.application'
 
-apply plugin: 'kotlin-android'
-
-apply plugin: 'kotlin-android-extensions'
-
 android {
     compileSdkVersion 28
     defaultConfig {
@@ -30,17 +26,11 @@ android {
 }
 
 dependencies {
-    implementation fileTree(include: ['*.jar'], dir: 'libs')
-    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation fileTree(dir: 'libs', include: ['*.jar'])
     implementation 'com.android.support:appcompat-v7:28.0.0'
     implementation 'com.android.support.constraint:constraint-layout:1.1.3'
-//    implementation 'com.android.volley:volley:1.1.1'
     implementation 'com.loopj.android:android-async-http:1.4.9'
     implementation 'org.jsoup:jsoup:1.7.2'
-    implementation group: 'commons-io', name: 'commons-io', version: '2.4'
-//    implementation 'com.squareup.retrofit2:retrofit:2.1.0'
-//    implementation 'com.google.code.gson:gson:2.8.2'
-//    implementation 'com.squareup.retrofit2:converter-gson:2.1.0'
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'

app/src/androidTest/java/eu/dasancti/reversee/ExampleInstrumentedTest.java

@@ -0,0 +1,26 @@
+package eu.dasancti.reversee;
+
+import android.content.Context;
+import android.support.test.InstrumentationRegistry;
+import android.support.test.runner.AndroidJUnit4;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import static org.junit.Assert.*;
+
+/**
+ * Instrumented test, which will execute on an Android device.
+ *
+ * @see <a href="http://d.android.com/tools/testing">Testing documentation</a>
+ */
+@RunWith(AndroidJUnit4.class)
+public class ExampleInstrumentedTest {
+    @Test
+    public void useAppContext() {
+        // Context of the app under test.
+        Context appContext = InstrumentationRegistry.getTargetContext();
+
+        assertEquals("eu.dasancti.reversee", appContext.getPackageName());
+    }
+}

app/src/main/AndroidManifest.xml

@@ -1,6 +1,5 @@
-<?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="eu.dasancti.reversee">
+    package="eu.dasancti.reversee">
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.INTERNET" />
 
@@ -10,7 +9,7 @@
             android:label="@string/app_name"
             android:roundIcon="@mipmap/ic_launcher_round"
             android:supportsRtl="true"
-            android:theme="@style/AppTheme">
+            android:theme="@style/Theme.AppCompat.DayNight.NoActionBar">
         <activity android:name=".MainActivity">
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
@@ -19,5 +18,4 @@
             </intent-filter>
         </activity>
     </application>
-
-</manifest>
+</manifest>

app/src/main/java/eu/dasancti/reversee/MainActivity.java

@@ -5,7 +5,10 @@
 import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.Bundle;
+import android.support.annotation.NonNull;
+import android.support.v4.app.ActivityCompat;
 import android.support.v4.content.ContextCompat;
+import android.support.v7.app.AlertDialog;
 import android.support.v7.app.AppCompatActivity;
 import android.util.Log;
 import android.widget.TextView;
@@ -33,8 +36,10 @@ public class MainActivity extends AppCompatActivity {
     private static final String API_SCH_VALUE = "sch";
     private static final String API_ENCODED_IMAGE_KEY = "encoded_image";
     private static final String API_USER_AGENT_KEY = "User-Agent";
+    private static final int REQUEST_PERMISSION_EXTERNAL_STORAGE_STATE = 99;
 
     private TextView progressStatus;
+    private Uri requestPermissionsFallbackUri;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -45,24 +50,64 @@ protected void onCreate(Bundle savedInstanceState) {
 
         Intent intent = getIntent();
         String action = intent.getAction();
+        if (action == null) {
+            Toast.makeText(MainActivity.this, "No action sent to application, closing.", Toast.LENGTH_SHORT).show();
+            this.finish();
+            return;
+        }
         if (isPermissionGranted()) {
             if (action.equals(Intent.ACTION_SEND)) {
                 progressStatus.setText(getString(R.string.progress_status_recieved_intent));
                 try {
-                    handleImageSearch(intent);
+                    handleImageSearch(intent.getParcelableExtra(Intent.EXTRA_STREAM));
                 } catch (FileNotFoundException e) {
                     String err = "Failed to handle Share image intent:"+e.getMessage();
                     Log.e("INTENT_HANDLE",err);
                     Toast.makeText(getApplicationContext(), err, Toast.LENGTH_SHORT).show();
                 }
             }
         } else {
-            Toast.makeText(this, "The app wasn't allowed permissions to manage files.", Toast.LENGTH_LONG).show();
+            android.support.v7.app.AlertDialog.Builder builder = new AlertDialog.Builder(this);
+            builder.setTitle("Read storage permission required.");
+            builder.setMessage("This application requires READ_EXTERNAL_STORAGE permission in order to function properly.");
+            builder.setPositiveButton("Grant permission", (dialog, which) -> {
+                ActivityCompat.requestPermissions(MainActivity.this, new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, REQUEST_PERMISSION_EXTERNAL_STORAGE_STATE);
+                if (action.equals(Intent.ACTION_SEND)) {
+                    requestPermissionsFallbackUri = intent.getParcelableExtra(Intent.EXTRA_STREAM);
+                }
+            });
+            builder.setNegativeButton("Deny permission", ((dialog, which) -> {
+                Toast.makeText(MainActivity.this, "Permission not granted, closing.", Toast.LENGTH_SHORT).show();
+                this.finish();
+            }));
+            builder.create().show();
+        }
+    }
+
+    @Override
+    public void onRequestPermissionsResult(int requestCode,
+                                           @NonNull String permissions[],
+                                           @NonNull int[] grantResults) {
+        switch (requestCode) {
+            case REQUEST_PERMISSION_EXTERNAL_STORAGE_STATE:
+                if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
+                    Toast.makeText(MainActivity.this, "Permission Granted!", Toast.LENGTH_SHORT).show();
+                    try {
+                        handleImageSearch(this.requestPermissionsFallbackUri);
+                    } catch (FileNotFoundException e) {
+                        String err = "Failed to handle Share image intent:"+e.getMessage();
+                        Log.e("INTENT_HANDLE",err);
+                        Toast.makeText(getApplicationContext(), err, Toast.LENGTH_SHORT).show();
+                    }
+                } else {
+                    Toast.makeText(MainActivity.this, "Permission not granted, closing.", Toast.LENGTH_SHORT).show();
+                    this.finish();
+                }
+                break;
         }
     }
 
-    private void handleImageSearch(Intent intent) throws FileNotFoundException {
-        Uri imageUri = intent.getParcelableExtra(Intent.EXTRA_STREAM);
+    private void handleImageSearch(Uri imageUri) throws FileNotFoundException {
         progressStatus.setText(getString(R.string.progress_status_handling_image));
         AtomicReference<String> reverseSearchRedirectURL = new AtomicReference<>();
         AsyncHttpClient asyncHttpClient = new AsyncHttpClient();

app/src/main/res/drawable-v24/ic_launcher_foreground.xml

@@ -1,34 +1,34 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
-        xmlns:aapt="http://schemas.android.com/aapt"
-        android:width="108dp"
-        android:height="108dp"
-        android:viewportHeight="108"
-        android:viewportWidth="108">
+    xmlns:aapt="http://schemas.android.com/aapt"
+    android:width="108dp"
+    android:height="108dp"
+    android:viewportHeight="108"
+    android:viewportWidth="108">
     <path
-            android:fillType="evenOdd"
-            android:pathData="M32,64C32,64 38.39,52.99 44.13,50.95C51.37,48.37 70.14,49.57 70.14,49.57L108.26,87.69L108,109.01L75.97,107.97L32,64Z"
-            android:strokeColor="#00000000"
-            android:strokeWidth="1">
+        android:fillType="evenOdd"
+        android:pathData="M32,64C32,64 38.39,52.99 44.13,50.95C51.37,48.37 70.14,49.57 70.14,49.57L108.26,87.69L108,109.01L75.97,107.97L32,64Z"
+        android:strokeColor="#00000000"
+        android:strokeWidth="1">
         <aapt:attr name="android:fillColor">
             <gradient
-                    android:endX="78.5885"
-                    android:endY="90.9159"
-                    android:startX="48.7653"
-                    android:startY="61.0927"
-                    android:type="linear">
+                android:endX="78.5885"
+                android:endY="90.9159"
+                android:startX="48.7653"
+                android:startY="61.0927"
+                android:type="linear">
                 <item
-                        android:color="#44000000"
-                        android:offset="0.0"/>
+                    android:color="#44000000"
+                    android:offset="0.0" />
                 <item
-                        android:color="#00000000"
-                        android:offset="1.0"/>
+                    android:color="#00000000"
+                    android:offset="1.0" />
             </gradient>
         </aapt:attr>
     </path>
     <path
-            android:fillColor="#FFFFFF"
-            android:fillType="nonZero"
-            android:pathData="M66.94,46.02L66.94,46.02C72.44,50.07 76,56.61 76,64L32,64C32,56.61 35.56,50.11 40.98,46.06L36.18,41.19C35.45,40.45 35.45,39.3 36.18,38.56C36.91,37.81 38.05,37.81 38.78,38.56L44.25,44.05C47.18,42.57 50.48,41.71 54,41.71C57.48,41.71 60.78,42.57 63.68,44.05L69.11,38.56C69.84,37.81 70.98,37.81 71.71,38.56C72.44,39.3 72.44,40.45 71.71,41.19L66.94,46.02ZM62.94,56.92C64.08,56.92 65,56.01 65,54.88C65,53.76 64.08,52.85 62.94,52.85C61.8,52.85 60.88,53.76 60.88,54.88C60.88,56.01 61.8,56.92 62.94,56.92ZM45.06,56.92C46.2,56.92 47.13,56.01 47.13,54.88C47.13,53.76 46.2,52.85 45.06,52.85C43.92,52.85 43,53.76 43,54.88C43,56.01 43.92,56.92 45.06,56.92Z"
-            android:strokeColor="#00000000"
-            android:strokeWidth="1"/>
+        android:fillColor="#FFFFFF"
+        android:fillType="nonZero"
+        android:pathData="M66.94,46.02L66.94,46.02C72.44,50.07 76,56.61 76,64L32,64C32,56.61 35.56,50.11 40.98,46.06L36.18,41.19C35.45,40.45 35.45,39.3 36.18,38.56C36.91,37.81 38.05,37.81 38.78,38.56L44.25,44.05C47.18,42.57 50.48,41.71 54,41.71C57.48,41.71 60.78,42.57 63.68,44.05L69.11,38.56C69.84,37.81 70.98,37.81 71.71,38.56C72.44,39.3 72.44,40.45 71.71,41.19L66.94,46.02ZM62.94,56.92C64.08,56.92 65,56.01 65,54.88C65,53.76 64.08,52.85 62.94,52.85C61.8,52.85 60.88,53.76 60.88,54.88C60.88,56.01 61.8,56.92 62.94,56.92ZM45.06,56.92C46.2,56.92 47.13,56.01 47.13,54.88C47.13,53.76 46.2,52.85 45.06,52.85C43.92,52.85 43,53.76 43,54.88C43,56.01 43.92,56.92 45.06,56.92Z"
+        android:strokeColor="#00000000"
+        android:strokeWidth="1" />
 </vector>

app/src/main/res/drawable/ic_launcher_background.xml

@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <vector
-        xmlns:android="http://schemas.android.com/apk/res/android"
-        android:height="108dp"
-        android:width="108dp"
-        android:viewportHeight="108"
-        android:viewportWidth="108">
+    android:height="108dp"
+    android:width="108dp"
+    android:viewportHeight="108"
+    android:viewportWidth="108"
+    xmlns:android="http://schemas.android.com/apk/res/android">
     <path android:fillColor="#008577"
           android:pathData="M0,0h108v108h-108z"/>
     <path android:fillColor="#00000000" android:pathData="M9,0L9,108"

app/src/main/res/values/strings.xml

@@ -1,6 +1,6 @@
 <resources>
     <string name="app_name">Reversee</string>
-    <string name="progress_status_recieved_intent">Recieved intent data (image share)</string>
+	<string name="progress_status_recieved_intent">Recieved intent data (image share)</string>
     <string name="progress_status_handling_image">Handling google reverse image search.</string>
     <string name="progress_status_response_success">Google request successful.</string>
     <string name="progress_status_redirect_found">Found redirect URL, opening browser intent.</string>

app/src/test/java/eu/dasancti/reversee/ExampleUnitTest.java

@@ -0,0 +1,17 @@
+package eu.dasancti.reversee;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+/**
+ * Example local unit test, which will execute on the development machine (host).
+ *
+ * @see <a href="http://d.android.com/tools/testing">Testing documentation</a>
+ */
+public class ExampleUnitTest {
+    @Test
+    public void addition_isCorrect() {
+        assertEquals(4, 2 + 2);
+    }
+}

build.gradle

@@ -1,14 +1,14 @@
 // Top-level build file where you can add configuration options common to all sub-projects/modules.
 
 buildscript {
-    ext.kotlin_version = '1.2.71'
+
     repositories {
         google()
         jcenter()
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.2.1'
-        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files