feat(action): Verify no matching cache before save #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this does not have appropriate testing, current status of PR is just production code changes. |
Kurt-von-Laven
requested changes
Apr 19, 2023
There was a problem hiding this comment.
This looks like a great start! I wonder if the failure in the Save Cache job can be addressed by disabling minification.
Commit message: "was indeed a new docker image(s) to save" --> "were indeed new Docker images to save"
mwarres
force-pushed
the
action
branch
3 times, most recently
from
f8fd9a2 to
27959c6
Compare
Kurt-von-Laven
requested changes
Apr 20, 2023
Kurt-von-Laven
requested changes
Nov 27, 2023
mwarres
force-pushed
the
action
branch
2 times, most recently
from
0f26ad9 to
a154f3d
Compare
Kurt-von-Laven
requested changes
Mar 6, 2024
Kurt-von-Laven
requested changes
Mar 6, 2024
Kurt-von-Laven
requested changes
Mar 10, 2024
Prior to saving cache, verify that there is no cache with a matching key already cached. Previously, we checked if a cache key matching our cache was present in the load step; if not, we would then proceed to attempt to save the cache in the save step (assuming we were not in read-only mode and that there were indeed new Docker images to save). This was problematic when the action was run in parallel; in that case, there were multiple, unnecessary cache save attempts when the cache initially missed but was subsequently saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135.
Prior to saving cache, verify that there is no cache with a matching key already cached. Previously, we checked if a cache key matching our cache was present in the load step; if not, we would then proceed to attempt to save the cache in the save step (assuming we were not in read-only mode and that there were indeed new Docker images to save). This was
problematic when the action was run in parallel; in that case, there were multiple, unnecessary cache save attempts when the cache initially missed but was subsequently saved.