Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Poetry): Group dev deps with updated syntax #610

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore(Poetry): Group dev deps with updated syntax #610

merged 1 commit into from
Sep 15, 2023

Conversation

mwarres
Copy link
Contributor

@mwarres mwarres commented Aug 9, 2023

Previously, development dependencies were grouped under [tool.poetry.dev-dependencies] in pyproject.toml. This syntax will soon be deprecated. Group development dependencies under [tool.poetry.group.dev.dependencies], the updated syntax as of Poetry v1.2.0.

@mwarres mwarres self-assigned this Aug 9, 2023
@mwarres mwarres requested a review from Kurt-von-Laven August 9, 2023 19:14
Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: the official Poetry docs say that the old syntax will be deprecated soon (but is not currently). Worth noting that the new syntax was released in Poetry 1.2.0.

@mwarres mwarres changed the title fix(Poetry): Group dev dependencies correctly chore(Poetry): Group dev deps with updated syntax Aug 9, 2023
@mwarres mwarres requested a review from Kurt-von-Laven August 9, 2023 20:54
@mwarres
Copy link
Contributor Author

mwarres commented Aug 23, 2023

@Kurt-von-Laven Are you able to take a look at this and see if it's ok?

Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

poetry.lock Outdated Show resolved Hide resolved
Previously, development dependencies were grouped under
[tool.poetry.dev-dependencies] in pyproject.toml. This syntax will soon
be deprecated. Group development dependencies under
[tool.poetry.group.dev.dependencies], the updated syntax as of Poetry
v1.2.0.
Copy link
Contributor

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwarres mwarres merged commit adcf317 into main Sep 15, 2023
7 checks passed
@mwarres mwarres deleted the Poetry branch September 15, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants