Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsconfig): Upgrade from node18 to node20 #810

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

Kurt-von-Laven
Copy link
Contributor

We already upgraded from Node.js v18 to v20, so use the appropriate base TypeScript config. The tsconfigs presently happen to be identical, but that could change, and it's confusing to use node18 while we are running Node.js v20.

We already upgraded from Node.js v18 to v20, so
use the appropriate base TypeScript config. The
tsconfigs presently happen to be identical, but
that could change, and it's confusing to use
node18 while we are running Node.js v20.
@Kurt-von-Laven Kurt-von-Laven requested a review from mwarres March 20, 2024 08:26
@Kurt-von-Laven Kurt-von-Laven self-assigned this Mar 20, 2024
@Kurt-von-Laven Kurt-von-Laven changed the title chore(tsconfig): Upgrade from node18 to node20 chore(tsconfig): Upgrade from node18 to node20 Mar 20, 2024
Copy link
Contributor

@mwarres mwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kurt-von-Laven Kurt-von-Laven merged commit c7eb178 into main Mar 21, 2024
9 checks passed
@Kurt-von-Laven Kurt-von-Laven deleted the tsconfig branch March 21, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants