feat(docker): Support dangling Docker images #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker images that were overwritten by a new one with the same name and tag do not have a name or tag. Docker images that were pulled by digest do not have a tag. Support the former by falling back on their ID and the latter by using their name. These changes prevent the action from crashing on such images. Continue using both the name and tag for images that have them so that they are retained upon restoring the cache.
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #572.
Docker images that were overwritten by a new one with the same name and tag do not have a name or tag. Docker images that were pulled by digest do not have a tag. Support the former by falling back on their ID and the latter by using their name.
These changes prevent the action from crashing on such images. Continue using both the name and tag for images that have them so that they are retained upon restoring the cache.