Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI and few other things #9

Closed
wants to merge 8 commits into from
Closed

Update CI and few other things #9

wants to merge 8 commits into from

Conversation

permanentdaylightt
Copy link
Contributor

No description provided.

ScriptedSnark
ScriptedSnark reviewed Oct 4, 2024
View reviewed changes
Copy link
Owner

@ScriptedSnark ScriptedSnark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there MinHook reference? I know that original SPTLib uses MinHook but SvenBXT has modified, lite version without that library in favor of FuncHook.

ScriptedSnark
ScriptedSnark requested changes Oct 4, 2024
View reviewed changes
Copy link
Owner

@ScriptedSnark ScriptedSnark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BXT_LICENSE contains only and only BunnymodXT license because of borrowed BXT-specific code. SPTLib already has own license file. hltas, hlstrafe, taslogger, MinHook and others are parts of original BunnymodXT, not of SvenBXT.

ScriptedSnark
ScriptedSnark reviewed Oct 4, 2024
View reviewed changes
Copy link
Owner

@ScriptedSnark ScriptedSnark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of these changes in SPTLib-related headers?

ScriptedSnark
ScriptedSnark reviewed Oct 4, 2024
View reviewed changes
Copy link
Owner

@ScriptedSnark ScriptedSnark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .gitignore can be extended with lots of Visual Studio/IDEA/CMake temporary files/formats/binaries.

@permanentdaylightt
Copy link
Contributor Author

Well yeah youre right I might made some unrequired changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboardcrash32 keyboardcrash32 keyboardcrash32 left review comments

@ScriptedSnark ScriptedSnark ScriptedSnark requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@permanentdaylightt @ScriptedSnark @keyboardcrash32