-
-
Notifications
You must be signed in to change notification settings - Fork 41
feat(core): dashboard origin from request #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 61.76% 0.00% -61.77%
==========================================
Files 381 100 -281
Lines 30977 8615 -22362
==========================================
- Hits 19132 0 -19132
+ Misses 11845 8615 -3230
... and 331 files with indirect coverage changes
🚀 New features to boost your workflow:
|
🚀 Preview Deployments
|
?brawl merge |
📌 Commit 7efe8c1 has been approved and added to the merge queue. Requested by: @lennartkloock Approved by: @SimaoMoreira5228 |
🚨 Failed to create merge commit Errorcreate merge: GitHub: Base does not exist |
?brawl merge |
📌 Commit 7efe8c1 has been approved and added to the merge queue. Requested by: @lennartkloock Approved by: @SimaoMoreira5228 |
🎉 Build successful! Approved by: @SimaoMoreira5228 |
This PR adds the ability for the core service to take the dashboard origin from the request
Origin
header instead of a static config value. This has the advantage that the server can be used with any frontend independent of its URL.This fixes the login in the preview deployments. (like #604)