Skip to content

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Oct 4, 2025

This PR adds the ability for the core service to take the dashboard origin from the request Origin header instead of a static config value. This has the advantage that the server can be used with any frontend independent of its URL.
This fixes the login in the preview deployments. (like #604)

@lennartkloock lennartkloock requested review from a team as code owners October 4, 2025 21:38
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (b385ecd) to head (7efe8c1).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cloud/core/src/operations/login.rs 0.00% 20 Missing ⚠️
cloud/core/src/google_api.rs 0.00% 10 Missing ⚠️
cloud/ext-traits/src/http_ext.rs 0.00% 9 Missing ⚠️
cloud/core/src/http_ext.rs 0.00% 7 Missing ⚠️
cloud/core/src/operations/user_session_requests.rs 0.00% 3 Missing ⚠️
cloud/core/src/common.rs 0.00% 2 Missing ⚠️
cloud/core/src/operations/users.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #613       +/-   ##
==========================================
- Coverage   61.76%   0.00%   -61.77%     
==========================================
  Files         381     100      -281     
  Lines       30977    8615    -22362     
==========================================
- Hits        19132       0    -19132     
+ Misses      11845    8615     -3230     
Files with missing lines Coverage Δ
cloud/core/src/services/sessions.rs 0.00% <ø> (ø)
cloud/core/src/operations/users.rs 0.00% <0.00%> (ø)
cloud/core/src/common.rs 0.00% <0.00%> (ø)
cloud/core/src/operations/user_session_requests.rs 0.00% <0.00%> (ø)
cloud/core/src/http_ext.rs 0.00% <0.00%> (ø)
cloud/ext-traits/src/http_ext.rs 0.00% <0.00%> (ø)
cloud/core/src/google_api.rs 0.00% <0.00%> (ø)
cloud/core/src/operations/login.rs 0.00% <0.00%> (ø)

... and 331 files with indirect coverage changes

Components Coverage Δ
scuffle-aac ∅ <ø> (∅)
scuffle-amf0 ∅ <ø> (∅)
scuffle-av1 ∅ <ø> (∅)
scuffle-batching ∅ <ø> (∅)
scuffle-bootstrap ∅ <ø> (∅)
scuffle-bytes-util ∅ <ø> (∅)
scuffle-context 0.00% <ø> (-100.00%) ⬇️
scuffle-expgolomb ∅ <ø> (∅)
scuffle-ffmpeg ∅ <ø> (∅)
scuffle-flv ∅ <ø> (∅)
scuffle-future-ext ∅ <ø> (∅)
nutype-enum ∅ <ø> (∅)
scuffle-h264 ∅ <ø> (∅)
scuffle-http 0.00% <ø> (-86.22%) ⬇️
scuffle-metrics ∅ <ø> (∅)
postcompile ∅ <ø> (∅)
scuffle-pprof ∅ <ø> (∅)
scuffle-rtmp ∅ <ø> (∅)
scuffle-settings ∅ <ø> (∅)
scuffle-signal ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Oct 4, 2025

🚀 Preview Deployments

Deployment Status Preview URL
dashboard ⏭️ -
docs ⏭️ -
rustdoc https://docs-scuffle-ir2i2k91h-scufflecloud.vercel.app
cloud emails render ⏭️ -

@lennartkloock
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Oct 5, 2025

📌 Commit 7efe8c1 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @SimaoMoreira5228

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Oct 5, 2025

🚨 Failed to create merge commit

Error

create merge: GitHub: Base does not exist
Documentation URL: https://docs.github.com/rest/branches/branches#merge-a-branch

@lennartkloock
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Oct 5, 2025

📌 Commit 7efe8c1 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @SimaoMoreira5228

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Oct 5, 2025

⌛ Trying commit 7efe8c1 with merge 44b8e60...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Oct 5, 2025

🎉 Build successful!
Completed in 6:11

Approved by: @SimaoMoreira5228
Pushing 44b8e60 to main

@scuffle-brawl scuffle-brawl bot merged commit 44b8e60 into main Oct 5, 2025
17 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/core-any-origin branch October 5, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants