Skip to content

Conversation

SimaoMoreira5228
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

🚀 Preview Deployments

Deployment Status Preview URL
dashboard ⏭️ -
docs ⏭️ -
rustdoc ⏭️ -
cloud emails render ⏭️ -

@TroyKomodo
Copy link
Member

Few things:

  • we need to install dotslash in ci
  • update CONTRIBUTING.md
  • update nix shell
  • remove the bindeps builds

@SimaoMoreira5228 SimaoMoreira5228 force-pushed the simao/dotslash branch 4 times, most recently from 45f7085 to a86d877 Compare October 8, 2025 22:05
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a47c3de) to head (9720109).

⚠️ Current head 9720109 differs from pull request most recent head 9a27d66

Please upload reports for the commit 9a27d66 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #617       +/-   ##
=========================================
- Coverage   61.71%      0   -61.72%     
=========================================
  Files         383      0      -383     
  Lines       31000      0    -31000     
=========================================
- Hits        19132      0    -19132     
+ Misses      11868      0    -11868     

see 383 files with indirect coverage changes

Components Coverage Δ
scuffle-aac ∅ <ø> (∅)
scuffle-amf0 ∅ <ø> (∅)
scuffle-av1 ∅ <ø> (∅)
scuffle-batching ∅ <ø> (∅)
scuffle-bootstrap ∅ <ø> (∅)
scuffle-bytes-util ∅ <ø> (∅)
scuffle-context ∅ <ø> (∅)
scuffle-expgolomb ∅ <ø> (∅)
scuffle-ffmpeg ∅ <ø> (∅)
scuffle-flv ∅ <ø> (∅)
scuffle-future-ext ∅ <ø> (∅)
nutype-enum ∅ <ø> (∅)
scuffle-h264 ∅ <ø> (∅)
scuffle-http ∅ <ø> (∅)
scuffle-metrics ∅ <ø> (∅)
postcompile ∅ <ø> (∅)
scuffle-pprof ∅ <ø> (∅)
scuffle-rtmp ∅ <ø> (∅)
scuffle-settings ∅ <ø> (∅)
scuffle-signal ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SimaoMoreira5228 SimaoMoreira5228 changed the title Use dotslash instead of bazel bindeps Use rules_multitool instead of bazel bindeps Oct 8, 2025
@SimaoMoreira5228 SimaoMoreira5228 force-pushed the simao/dotslash branch 2 times, most recently from 25ae337 to 537691e Compare October 8, 2025 23:59
"binaries": [
{
"kind": "file",
"url": "https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-darwin-amd64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its okay to use the newer version of buildifier if we also add the following to the MODULE.bazel

bazelbuild/buildtools#1345 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants