Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small mistakes from last PR #44

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Fix small mistakes from last PR #44

merged 2 commits into from
Feb 19, 2023

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Feb 19, 2023

Proposed changes

Previous commit had a clear cache tool, which allowed CI to auto purge cached branches, however it did not have the write perm.

Also removing LTO and ticketing it to benchmark later. See #45 for more details.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@TroyKomodo TroyKomodo requested a review from a team as a code owner February 19, 2023 22:22
Fat LTO adds a lot of time to the build. We will have to do benchmarks
later to see if it provides any reasonable performance increases.
@TroyKomodo TroyKomodo changed the title fix: clean cache Fix small mistakes from last PR Feb 19, 2023
@TroyKomodo TroyKomodo requested a review from a team February 19, 2023 22:42
Copy link
Contributor

@4w3Official 4w3Official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TroyKomodo TroyKomodo merged commit f21a818 into main Feb 19, 2023
@TroyKomodo TroyKomodo deleted the troy/fix-clean-cache branch February 19, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants