Skip to content

Commit

Permalink
misc: drop experimental vaapi profiles
Browse files Browse the repository at this point in the history
They will soon be deprecated.
  • Loading branch information
SeaDve committed Jul 22, 2024
1 parent 05e2da7 commit 7d4fcc7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 36 deletions.
16 changes: 7 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,12 @@ performance degradation. However, they can be enabled manually by running Kooha
with `KOOHA_EXPERIMENTAL` env var set to `all` (e.g., `KOOHA_EXPERIMENTAL=all flatpak run io.github.seadve.Kooha`), or individually, by setting
`KOOHA_EXPERIMENTAL` to the following keys (e.g., `KOOHA_EXPERIMENTAL=experimental-formats,window-recording`):

| Feature | Description | Issues |
| ------------------------ | ------------------------------------------------------------------------ | ------------------------- |
| `all` | Enables all experimental features | - |
| `experimental-formats` | Enables other codecs (e.g., hardware-accelerate encoders*, VP9, and AV1) | Stability |
| `multiple-video-sources` | Enables recording multiple monitor or windows | Stability and performance |
| `window-recording` | Enables recording a specific window | Flickering |

\* Requires `GST_VAAPI_ALL_DRIVERS` env var to be set to `1` and `gstreamer-vaapi` to be installed.
| Feature | Description | Issues |
| ------------------------ | ----------------------------------------------------------------------- | ------------------------- |
| `all` | Enables all experimental features | - |
| `experimental-formats` | Enables other codecs (e.g., hardware-accelerate encoders, VP9, and AV1) | Stability |
| `multiple-video-sources` | Enables recording multiple monitor or windows | Stability and performance |
| `window-recording` | Enables recording a specific window | Flickering |

## 📋 Runtime Requirements

Expand Down Expand Up @@ -106,7 +104,7 @@ The following packages are required to build Kooha:
* gstreamer
* gstreamer-plugins-base
* gstreamer-plugins-ugly (for MP4)
* gstreamer-vaapi (for hardware acceleration)
* gstreamer-plugins-bad (for VA encoders)
* glib2
* gtk4
* libadwaita
Expand Down
26 changes: 0 additions & 26 deletions data/resources/profiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,29 +99,3 @@ experimental:
queue !
mpegaudioparse
muxer: mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise

- id: vaapi-vp8
name: WebM VAAPI VP8
extension: webm
videoenc: >
glupload ! glcolorconvert ! gldownload !
vaapivp8enc !
queue
audioenc: >
audioconvert !
opusenc !
queue
muxer: webmmux

- id: vaapi-vp9
name: WebM VAAPI VP9
extension: webm
videoenc: >
glupload ! glcolorconvert ! gldownload !
vaapivp9enc !
queue
audioenc: >
audioconvert !
opusenc !
queue
muxer: webmmux
2 changes: 1 addition & 1 deletion src/profile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ mod tests {

for profile in Profile::all().unwrap() {
// These profiles are not supported by the CI runner.
if matches!(profile.id(), "vaapi-vp8" | "vaapi-vp9" | "va-h264") {
if matches!(profile.id(), "va-h264") {
continue;
}

Expand Down

0 comments on commit 7d4fcc7

Please sign in to comment.