Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib panic on insert_many #2344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

j-mendez
Copy link

This removes the panic that happens on insert many.
We should not have panics in a library production code.

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 30, 2024

sorry, I don't think this is a proper fix, yes it removes the panic, but the resulting query will still be wrong.
ideally, we'd have to loop over the models a second time with a complete list of all columns to constuct the insert statement

@j-mendez
Copy link
Author

sorry, I don't think this is a proper fix, yes it removes the panic, but the resulting query will still be wrong.

ideally, we'd have to loop over the models a second time with a complete list of all columns to constuct the insert statement

@tyt2y3 hi do we want to add the code for the second loop? Can try to look into this. Right now forking the lib just to prevent this one panic since it shuts down my server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants