Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup about cloudfuse window #446

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Cleanup about cloudfuse window #446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d6a74
Cleanup about cloudfuse window and prevent opening command windows wh…
jfantinhardesty Feb 11, 2025
800944a
Fix grammar issues
jfantinhardesty Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions gui/aboutPage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,27 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE

from PySide6.QtWidgets import QWidget
from PySide6.QtGui import QFont
from PySide6.QtWidgets import QMessageBox
from PySide6.QtCore import Qt

# import the custom window class
from ui_about_dialog import Ui_About

class aboutPage(QWidget, Ui_About):
def __init__(self,cloudfuseVersion):
class aboutPage(QMessageBox):
def __init__(self, cloudfuseVersion: str):
super().__init__()
self.setupUi(self)

# By default, hyperlinks are set to look for local files in the current directory; set the behavior to open the
# external link in the system's default browser
self.textBrowser.setOpenExternalLinks(True)
self.labelcloudfuseVersion.setText(str(cloudfuseVersion).capitalize())
self.labelcloudfuseVersion.setFont(QFont('Arial',18,700))

# Close the window when the ok button is clicked
self.buttonBox.clicked.connect(self.close)
self.setWindowTitle("About Cloudfuse")
self.setTextFormat(Qt.RichText)
self.setText(f"""
<p><strong><h3>About Cloudfuse</h3></strong></p>
<p>The program using Cloudfuse version {cloudfuseVersion}</p>
<p>Cloudfuse provides a virtual filesystem backed by either S3 or Azure Storage for mounting the cloud to a local system.</p>
<p>For more information and frequently asked questions please go to the <a href="https://github.com/Seagate/cloudfuse">Cloudfuse GitHub</a>.</p>
<p><h4>Help</h4></p>
<p>Found a bug? Report it at the <a href="https://github.com/Seagate/cloudfuse/issues">github issues</a> with the bug label.</p>
<p>Have questions not in the FAQ? Submit it at the <a href="https://github.com/Seagate/cloudfuse/issues">github issues</a> with the question label.</p>
<p><h4>Third Party Notices</h4></p>
<p>See <a href="NOTICE">notices</a> for third party license notices.</p>
<p>WinSFP is licensed under the GPLv3 license with a special exception for Free/Libre and Open Source Software, which is available <a href="https://github.com/winfsp/winfsp/blob/master/License.txt">here</a>.</p>
<p><h4>Attribution</h4></p>
<p>WinSFP - Windows File System Proxy, Copyright Bill Zissimopoulos <a href="https://github.com/winfsp/winfsp">details</a>.</p>
<p><h4>License</h4></p>
<p>This project is licensed under MIT.</p>
""")
71 changes: 0 additions & 71 deletions gui/about_dialog.ui
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion gui/mountPrimaryWindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,10 @@ def runCommand(self, commandParts):
return ('', '', -1, False)
# run command
try:
process = subprocess.run(commandParts, capture_output=True)
process = subprocess.run(
commandParts,
capture_output=True,
creationflags=subprocess.CREATE_NO_WINDOW if hasattr(subprocess, 'CREATE_NO_WINDOW') else 0)
stdOut = process.stdout.decode().strip()
stdErr = process.stderr.decode().strip()
exitCode = process.returncode
Expand Down
Loading