Allow GUI to only mount as a drive letter on Windows #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker and
foodprocessor
as code owners
foodprocessor
approved these changes
Feb 14, 2025
|
Can you push a screenshot of this in action into this PR's description so we can see it without having to build it? |
Ferelith-maker
requested changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This changes the GUI to only allow mounting as a drive letter on Windows, to reduce user confusion and simplify the Windows mounting process. It replaces the browse button with one for drive letters that display the available drive letters to mount on. The old code is still there, so you can manually type a path and still mount to it, but the browse button in gone.
Here is how the GUI looks now on Windows.
Checklist
Related Issues