Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #40

Merged
merged 21 commits into from
Aug 16, 2024
Merged

Add logging #40

merged 21 commits into from
Aug 16, 2024

Conversation

Dabnsky
Copy link
Contributor

@Dabnsky Dabnsky commented Aug 5, 2024

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Added NX_PRINT outputs throughout the settingsReceived() for more debug logging information.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Copy link
Collaborator

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want a few prints in other files as well.
For example, maybe something for when the plugin first starts running.

src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Show resolved Hide resolved
Copy link
Collaborator

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cleanup.

src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally found where this output goes, and it turns out they add endlines for us.
So all the std::endl parts need to be removed.

Copy link
Collaborator

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my clang format bug! 😅

@Dabnsky Dabnsky merged commit fe95ec4 into main Aug 16, 2024
12 checks passed
@Dabnsky Dabnsky deleted the add-logging branch August 16, 2024 17:49
@foodprocessor foodprocessor restored the add-logging branch August 16, 2024 18:03
@foodprocessor foodprocessor deleted the add-logging branch August 16, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants