Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging #48

Merged
merged 21 commits into from
Aug 16, 2024
Merged

Add logging #48

merged 21 commits into from
Aug 16, 2024

Conversation

foodprocessor
Copy link
Collaborator

Redoing the merge for this PR so we can squash the commits.

@Dabnsky
added NX_PRINT outputs for all error returns
bb5eed3
@Dabnsky
added NX_PRINT lines for general info
18ddd3b
@Dabnsky
added another error NX_PRINT line before return
1924124
@Dabnsky
Removed "generated passphrase" print
01765ca
@Dabnsky
dropped checking mountDir has correct permissions print
460197b
@Dabnsky
added "the mount directory does not exist" to print
0f82967
@Dabnsky
moved print to else block and modified it to "creating file cache sin…
d7177ab 
…ce it does not exist"
@Dabnsky
moved spawn prococess prints out of platform specific conditional cod…
5dcbc85 
…e blocks
@Dabnsky
added print for error on active settings
3b703ea
@Dabnsky
adjusted mount directory error print
fc666b0
@Dabnsky
added error logging for mounting dir
d7a1bfc
@Dabnsky
moved Print into if code block
4f9c63a
@Dabnsky
corrected print location above if condtion and in function scope
a5f551a
@Dabnsky
pulled print out from platform flags
9ccf165
@Dabnsky
pulled print out of platform flags for dryRun
1c25782
@Dabnsky
Merge commit 'e235b2c1156439804653c0957d5a223de30f434d' into add-logging
ad13038
@Dabnsky
ran clang-format on file
20f938d
@Dabnsky
ran clang-format on file in question for github action
458089d
@Dabnsky
removed std:endl on all NX_PRINT lines
a160f05
@Dabnsky
removed remaining std::endl of NX_PRINT lines
989c758
@Dabnsky
removed empty line
dbdbb4c
@foodprocessor foodprocessor merged commit 0969522 into main Aug 16, 2024
21 checks passed
@foodprocessor foodprocessor deleted the add-logging branch August 16, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfantinhardesty jfantinhardesty jfantinhardesty approved these changes

@Dabnsky Dabnsky Awaiting requested review from Dabnsky Dabnsky is a code owner

@Ferelith-maker Ferelith-maker Awaiting requested review from Ferelith-maker Ferelith-maker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foodprocessor @jfantinhardesty @Dabnsky