Enable stderr logging #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs when printing outside of member functions.
foodprocessor
requested review from
Dabnsky,
Ferelith-maker and
jfantinhardesty
as code owners
jfantinhardesty
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mediaserver will log our NX_PRINT output to stderr. On Linux, that is written to a service log (visible with journalctl), but on Windows it is lost.
To capture this output to a file, developers are told to use "OutputRedirector" by creating output redirection files, as described in the Nx Meta documentation, and on the forum: here.
With this change, the plugin will go and create those files itself, so that NX_PRINT output will be captured in deployment.
NOTE: output redirection requires restarting the mediaserver again after the plugin creates the redirection files.
This logging method is not great, but it's an improvement over our current situation (no plugin logs are captured on Windows).
What type of Pull Request is this? (check all applicable)
Checklist