Skip to content

Commit

Permalink
Skip TestContextCancellation on Windows GitHub runner
Browse files Browse the repository at this point in the history
  • Loading branch information
SebastiaanKlippert committed Jun 23, 2024
1 parent a861526 commit efe6a20
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Windows tests only
name: Windows manual tests

on: workflow_dispatch

Expand Down
6 changes: 5 additions & 1 deletion wkhtmltopdf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"os/exec"
"path/filepath"
"reflect"
"runtime"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -127,7 +128,10 @@ func TestGeneratePDF(t *testing.T) {
}

func TestContextCancellation(t *testing.T) {
t.SkipNow()
if os.Getenv("GITHUB_ACTIONS") == "true" && runtime.GOOS == "windows" {
t.Skip("temporarily skipping on Windows Github actions, because it blocks. Most likely on due to WindowStatus being set, need to investigate")
}

pdfg := newTestPDFGenerator(t)
htmlfile, err := os.ReadFile("testdata/htmlsimple.html")
if err != nil {
Expand Down

0 comments on commit efe6a20

Please sign in to comment.