fix: language plugin check

Disable language plugin check because of false positives and edge cases across platforms. The original check mechanism also prevents loading custom plugins.
Sec-ant · Feb 20, 2024 · 130e8e5 · 130e8e5
1 parent 595744c
commit 130e8e5
Show file tree

Hide file tree

Showing 17 changed files with 1 addition and 74 deletions.
diff --git a/src/embedded/glsl/embedder.ts b/src/embedded/glsl/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-glsl", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/ini/embedder.ts b/src/embedded/ini/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-ini", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/java/embedder.ts b/src/embedded/java/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-java", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/jsonata/embedder.ts b/src/embedded/jsonata/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,12 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound(
-    "@stedi/prettier-plugin-jsonata",
-    options,
-    commentOrTag,
-  );
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/latex/embedder.ts b/src/embedded/latex/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-latex", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/nginx/embedder.ts b/src/embedded/nginx/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-nginx", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/pegjs/embedder.ts b/src/embedded/pegjs/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-pegjs", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/php/embedder.ts b/src/embedded/php/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("@prettier/plugin-php", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/prisma/embedder.ts b/src/embedded/prisma/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-prisma", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/properties/embedder.ts b/src/embedded/properties/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-properties", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/pug/embedder.ts b/src/embedded/pug/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("@prettier/plugin-pug", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/ruby/embedder.ts b/src/embedded/ruby/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("@prettier/plugin-ruby", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/sh/embedder.ts b/src/embedded/sh/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-sh", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/sql/embedder.ts b/src/embedded/sql/embedder.ts
@@ -6,7 +6,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -26,8 +25,6 @@ export const embedder: Embedder<Options> = async (
 
   const plugin = resolvedOptions.embeddedSqlPlugin ?? "prettier-plugin-sql";
 
-  throwIfPluginIsNotFound(plugin, resolvedOptions, commentOrTag);
-
   const { node } = path;
 
   const { createPlaceholder, placeholderRegex } = preparePlaceholder();

diff --git a/src/embedded/toml/embedder.ts b/src/embedded/toml/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("prettier-plugin-toml", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,

diff --git a/src/embedded/utils.ts b/src/embedded/utils.ts
@@ -1,5 +1,5 @@
 import type { Comment, Expression, TemplateLiteral } from "estree";
-import type { AstPath, Doc, Options } from "prettier";
+import type { AstPath, Doc } from "prettier";
 import { builders, utils } from "prettier/doc";
 import type {
   LiteralUnion,
@@ -69,27 +69,6 @@ export function simpleRehydrateDoc(
   return contentDoc;
 }
 
-export function throwIfPluginIsNotFound(
-  pluginName: string,
-  options: Options,
-  commentOrTag: string,
-) {
-  if (
-    !(
-      options.plugins?.some(
-        (p) =>
-          (p as { name?: string }).name?.match(
-            new RegExp(`(^|/)${escapeRegExp(pluginName)}($|/)`),
-          ) ?? false,
-      ) ?? false
-    )
-  ) {
-    throw new Error(
-      `Cannot format embedded language identified by "${commentOrTag}", because plugin "${pluginName}" is not loaded.`,
-    );
-  }
-}
-
 export function insertLanguage(
   languages: string[],
   language: string,

diff --git a/src/embedded/xml/embedder.ts b/src/embedded/xml/embedder.ts
@@ -5,7 +5,6 @@ import {
   preparePlaceholder,
   printTemplateExpressions,
   simpleRehydrateDoc,
-  throwIfPluginIsNotFound,
 } from "../utils.js";
 import { language } from "./language.js";
 
@@ -18,8 +17,6 @@ export const embedder: Embedder<Options> = async (
   options,
   { commentOrTag, embeddedOverrideOptions },
 ) => {
-  throwIfPluginIsNotFound("@prettier/plugin-xml", options, commentOrTag);
-
   const resolvedOptions = {
     ...options,
     ...embeddedOverrideOptions,