Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularizes Echo, "Ports" Phytosians #11

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

Ms-Mee
Copy link
Contributor

@Ms-Mee Ms-Mee commented Feb 19, 2024

About The Pull Request

"Ports" Phytosians from Yogs, that is to say replaces podpeople with my take on them and makes them roundstart.

Modularizes the files I've changed in the past to take us off future marg conflict hell.

  • Phytosian lore Later
  • Rebalancing, they're weird and feel a little too strong presently Later
  • Make sure the modular folder works properly
  • Fix tests
  • Do whatever else I am told to achieve

Why It's Good For The Game

Modular folder, interesting new species.

Changelog

🆑
add: phytosian hairs, lungs and wings
code: changed podpeople code and related sprite accessories
code: changed breathing code
code: modularized my changes to echo, others' not yet
config: roundstart plant
imageadd: phytosian hairs, lungs and wings
/:cl:

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 19, 2024

It's so joever(When I'm done with it I'll do prefs stuff since I don't have classes currently)

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 20, 2024

"Gonna finish it tomorrow"

The devilish human nervous and immunological systems about to ruin my plans:

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

I do miss having a desk, it forced me to not be lazy on the computer

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

THE NEFARIOUS TGS

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

image

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Can't wait to be told I did it wrong

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Linters... My mortal enemy...

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Wait why did it revert that changelog commit what

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Doing time travel shenanigans don't worry about it

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

image

@Ms-Mee Ms-Mee reopened this Feb 24, 2024
@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

I'll do the changes I plan on later today if this is indeed how modularization should be, and then start the prefs things (horror)

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Desire for Approval (or Approval Desire) by Aiobahn.mp3

@TheNeoGamer42
Copy link
Contributor

There a reason you have the echo specific defines in the code folder and not the echo13 folder?

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 24, 2024

Defines only work for code that appears after them, so that is where a modular define folder goes even if presently it doesn't matter, better having it where it should be now than having to move the whole folder later

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 25, 2024

Gonna leave vampire phytosians to way later because it's just not gonna work the way I want for now

Also trying an echo dme replacement so we don't get dme merge conflicts later and such

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 25, 2024

Wait did I trick myself into modularizing vampires now with the prospect of vampire phytosians but then decide to not do vampire phytosians what the hell

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 25, 2024

Although sap blood means I kinda had to anyways

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 25, 2024

My form empties

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Feb 25, 2024

One can hope everything works right and fine (it won't)

@Ms-Mee Ms-Mee changed the title "Ports" Phytosians:tm: (Not done) (Evil) Modularizes Echo, "Ports" Phytosians Feb 25, 2024
@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Mar 2, 2024

Not gonna change this further other than eventual lore unless I run into something I missed while testing backstories and languages so

@Ms-Mee Ms-Mee marked this pull request as ready for review March 2, 2024 04:33
@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Mar 6, 2024

image

@TheNeoGamer42 TheNeoGamer42 merged commit 33f6027 into Sector-Echo-13-Team:master Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants