Skip to content

Commit

Permalink
Merge branch 'puigmontella-overSedDyMFoam' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
CyrilleBonamy committed Apr 11, 2024
2 parents d0dddeb + b801c50 commit 21171eb
Show file tree
Hide file tree
Showing 771 changed files with 391,460 additions and 194 deletions.
22 changes: 11 additions & 11 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
docs-build:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312

environment:
WM_NCOMPPROCS: 2
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:

build:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312

environment:
WM_NCOMPPROCS: 2
Expand Down Expand Up @@ -162,12 +162,12 @@ jobs:
shopt -s expand_aliases && source /openfoam/bash.rc &&
export FOAM_USER_LIBBIN=$FOAM_SITE_LIBBIN && ./Allwmake -prefix=group
- persist_to_workspace:
root: /usr/lib/openfoam/openfoam2212
root: /usr/lib/openfoam/openfoam2312
paths: site

test:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312
working_directory: /root/sedfoam

steps:
Expand All @@ -184,7 +184,7 @@ jobs:
path: /root/sedfoam

- attach_workspace:
at: /usr/lib/openfoam/openfoam2212
at: /usr/lib/openfoam/openfoam2312

- run:
name: sedfoam test1D sedim
Expand All @@ -207,7 +207,7 @@ jobs:

advanced-test:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312
working_directory: /root/sedfoam

steps:
Expand All @@ -224,7 +224,7 @@ jobs:
path: /root/sedfoam

- attach_workspace:
at: /usr/lib/openfoam/openfoam2212
at: /usr/lib/openfoam/openfoam2312

- run:
name: sedfoam 1D AvalancheMuI
Expand All @@ -237,7 +237,7 @@ jobs:

advanced-test1:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312
working_directory: /root/sedfoam

steps:
Expand All @@ -254,7 +254,7 @@ jobs:
path: /root/sedfoam

- attach_workspace:
at: /usr/lib/openfoam/openfoam2212
at: /usr/lib/openfoam/openfoam2312

- run:
name: sedfoam 1DBedLoadTurb
Expand All @@ -277,7 +277,7 @@ jobs:

advanced-test2:
docker:
- image: opencfd/openfoam-dev:2212
- image: opencfd/openfoam-dev:2312
working_directory: /root/sedfoam

steps:
Expand All @@ -294,7 +294,7 @@ jobs:
path: /root/sedfoam

- attach_workspace:
at: /usr/lib/openfoam/openfoam2212
at: /usr/lib/openfoam/openfoam2312

- run:
name: sedfoam 1DWetAvalanche
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

build:
runs-on: ubuntu-latest
container: opencfd/openfoam-dev:2212
container: opencfd/openfoam-dev:2312
steps:
- name: install git
run: |
Expand All @@ -30,12 +30,12 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: sedfoam-binary
path: /usr/lib/openfoam/openfoam2212/site
path: /usr/lib/openfoam/openfoam2312/site

test:
runs-on: ubuntu-latest
container:
image: opencfd/openfoam-dev:2212
image: opencfd/openfoam-dev:2312
needs: [build, checkstyle, checkpep8]
defaults:
run:
Expand All @@ -53,10 +53,10 @@ jobs:
- uses: actions/download-artifact@v2
with:
name: sedfoam-binary
path: /usr/lib/openfoam/openfoam2212/site
path: /usr/lib/openfoam/openfoam2312/site
- name: chmod sedfoam binary
run: chmod a+x -R *
working-directory: /usr/lib/openfoam/openfoam2212/site
working-directory: /usr/lib/openfoam/openfoam2312/site
- name: sedfoam test1D sedim
run: |
shopt -s expand_aliases && source /openfoam/bash.rc &&
Expand All @@ -74,7 +74,7 @@ jobs:
advanced-test:
runs-on: ubuntu-latest
container:
image: opencfd/openfoam-dev:2212
image: opencfd/openfoam-dev:2312
needs: [test]
defaults:
run:
Expand All @@ -91,10 +91,10 @@ jobs:
- uses: actions/download-artifact@v2
with:
name: sedfoam-binary
path: /usr/lib/openfoam/openfoam2212/site
path: /usr/lib/openfoam/openfoam2312/site
- name: chmod sedfoam binary
run: sudo chmod a+x -R *
working-directory: /usr/lib/openfoam/openfoam2212/site
working-directory: /usr/lib/openfoam/openfoam2312/site
- name: sedfoam test1D AvalancheMuI
run: |
shopt -s expand_aliases && source /openfoam/bash.rc &&
Expand All @@ -105,7 +105,7 @@ jobs:
advanced-test1:
runs-on: ubuntu-latest
container:
image: opencfd/openfoam-dev:2212
image: opencfd/openfoam-dev:2312
needs: [test]
defaults:
run:
Expand All @@ -122,10 +122,10 @@ jobs:
- uses: actions/download-artifact@v2
with:
name: sedfoam-binary
path: /usr/lib/openfoam/openfoam2212/site
path: /usr/lib/openfoam/openfoam2312/site
- name: chmod sedfoam binary
run: sudo chmod a+x -R *
working-directory: /usr/lib/openfoam/openfoam2212/site
working-directory: /usr/lib/openfoam/openfoam2312/site
- name: sedfoam test 1DBedLoadTurb
run: |
shopt -s expand_aliases && source /openfoam/bash.rc &&
Expand All @@ -141,7 +141,7 @@ jobs:
advanced-test2:
runs-on: ubuntu-latest
container:
image: opencfd/openfoam-dev:2212
image: opencfd/openfoam-dev:2312
needs: [test]
defaults:
run:
Expand All @@ -158,10 +158,10 @@ jobs:
- uses: actions/download-artifact@v2
with:
name: sedfoam-binary
path: /usr/lib/openfoam/openfoam2212/site
path: /usr/lib/openfoam/openfoam2312/site
- name: chmod sedfoam binary
run: sudo chmod a+x -R *
working-directory: /usr/lib/openfoam/openfoam2212/site
working-directory: /usr/lib/openfoam/openfoam2312/site
- name: sedfoam test 1DWetAvalanche
run: |
shopt -s expand_aliases && source /openfoam/bash.rc &&
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

docs-build:
runs-on: ubuntu-latest
container: opencfd/openfoam-dev:2212
container: opencfd/openfoam-dev:2312
steps:
- name: install docs package
run: |
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:

docs-deploy:
runs-on: ubuntu-latest
container: opencfd/openfoam-dev:2212
container: opencfd/openfoam-dev:2312
needs: docs-build
steps:
- name: install git
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

build:
runs-on: ubuntu-latest
container: opencfd/openfoam-dev:2212
container: opencfd/openfoam-dev:2312
steps:
- name: install git
run: |
Expand All @@ -29,7 +29,7 @@ jobs:
docker:
runs-on: ubuntu-latest
env:
IMAGE_NAME: sedfoam_2212_ubuntu
IMAGE_NAME: sedfoam_2312_ubuntu
needs: build
steps:
- name: Checkout repository
Expand All @@ -56,7 +56,7 @@ jobs:
docker_nb:
runs-on: ubuntu-latest
env:
IMAGE_NAME: sedfoam_2212_notebook
IMAGE_NAME: sedfoam_2312_notebook
needs: docker
steps:
- name: Checkout repository
Expand Down
4 changes: 3 additions & 1 deletion Allwclean
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ then
echo " no 'wclean' command" 1>&2
exit 2
fi

forcesSedFoam/Allwclean $targetType $*
sixDoFRigidBodyMotionSedFoam/Allwclean $targetType $*
TurbulenceModels/Allwclean $*
solver/Allwclean $*
solverMULES/Allwclean $*


#------------------------------------------------------------------------------
3 changes: 2 additions & 1 deletion Allwmake
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ echo " prefix = ${FOAM_MODULE_PREFIX:-default (user)}"
echo

#------------------------------------------------------------------------------

forcesSedFoam/Allwmake $targetType $*
sixDoFRigidBodyMotionSedFoam/Allwmake $targetType $*
TurbulenceModels/Allwmake $targetType $*
solver/Allwmake $targetType $*
solverMULES/Allwmake $targetType $*
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Developers
* Cyrille Bonamy
* Julien Chauchat
* Antoine Mathieu
* Eduard Puig Montella
* Eduard Puig Montellà
* Rémi Chassagne
* Zhen Cheng
* Tim Nagel
Expand Down
5 changes: 3 additions & 2 deletions doc/Doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,7 @@ INPUT = index.doc \
tutorials_laminar.doc \
tutorials_RAS.doc \
tutorials_LES.doc \
tutorials_DyM.doc \
publications.doc \
input.doc \
howtogit.doc \
Expand Down Expand Up @@ -1223,7 +1224,7 @@ HTML_HEADER =
# that doxygen normally uses.
# This tag requires that the tag GENERATE_HTML is set to YES.

HTML_FOOTER =
HTML_FOOTER =

# The HTML_STYLESHEET tag can be used to specify a user-defined cascading style
# sheet that is used by each HTML page. It can be used to fine-tune the look of
Expand Down Expand Up @@ -1661,7 +1662,7 @@ MATHJAX_EXTENSIONS = TeX/AMSmath \
# example see the documentation.
# This tag requires that the tag USE_MATHJAX is set to YES.

MATHJAX_CODEFILE =
MATHJAX_CODEFILE =

# When the SEARCHENGINE tag is enabled doxygen will generate a search box for
# the HTML output. The underlying search engine uses javascript and DHTML and
Expand Down
1 change: 1 addition & 0 deletions doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
("Laminar flow Tutorials", 'tutorials_laminar'),
("Turbulence-averaged flow tutorials", 'tutorials_RAS'),
("Turbulence-resolving flow tutorials", 'tutorials_LES'),
("Dynamic mesh tutorials", 'tutorials_DyM'),
("Input description", 'inputs')
])
]
Expand Down
10 changes: 5 additions & 5 deletions doc/governingEq.doc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ The drag parameter \f$K\f$, is modeled following Schiller and Naumann (1933):
K=0.75 C_d \frac{\rho^b}{d_{eff}} \parallel \mathbf{u^b}-\mathbf{u^a}\parallel\beta^{-h_{Exp}} \tag{5}
\f]

where \f$d_{eff}= {\psi}d\f$ is the effective sediment diameter, in which \f$\psi\f$ is the shape factor and \f$d\f$ is the particle diameter. The hindrance function \f$\beta^{-h_{Exp}}\f$ represents the drag increase when the particle volume concentration increases. \f$h_{Exp}\f$ is the hindrance exponent that depends on the particulate Reynolds number (Di Felice (1994)). For simplicity, the value of \f$h_{Exp}\f$ is assumed to be constant (default value is 2.65), and its value can be specified from the *constant/transportProperties* file in SedFoam-2212. This hypothesis is valid for particulate Reynolds numbers lower than unity or larger than 300, within this range the exponent value decreases down to \f$h_{Exp}\approx2\f$. The drag coefficient \f$C_d\f$ is calculated as:
where \f$d_{eff}= {\psi}d\f$ is the effective sediment diameter, in which \f$\psi\f$ is the shape factor and \f$d\f$ is the particle diameter. The hindrance function \f$\beta^{-h_{Exp}}\f$ represents the drag increase when the particle volume concentration increases. \f$h_{Exp}\f$ is the hindrance exponent that depends on the particulate Reynolds number (Di Felice (1994)). For simplicity, the value of \f$h_{Exp}\f$ is assumed to be constant (default value is 2.65), and its value can be specified from the *constant/transportProperties* file in SedFoam-2312. This hypothesis is valid for particulate Reynolds numbers lower than unity or larger than 300, within this range the exponent value decreases down to \f$h_{Exp}\approx2\f$. The drag coefficient \f$C_d\f$ is calculated as:

\f[
C_d=\left\{
Expand All @@ -52,7 +52,7 @@ C_d=\left\{
\right. \tag{6}
\f]

in which, the particulate Reynolds number \f$Re_p\f$ is defined as: \f$Re_p=\beta\parallel\mathbf{u^b-u^a}\parallel d_{eff}/\nu^b\f$, where \f$\nu^b\f$ stands for the fluid kinematic viscosity. This drag model can be chosen by the keyword ``GidaspowSchillerNaumann'' in the file *constant/interfacialProperties* and it is especially well adapted for dealing with suspended particles. For situations in which the fluid flow inside the porous sediment bed has to be accurately solved, other drag models are available in SedFoam-2212. The major issue in developing an Eulerian two-phase flow model is to provide closure laws for turbulence closures and granular stress models. This will be extensively discussed in the following subsections, particularly different modeling options available in SedFoam-2212  are presented.
in which, the particulate Reynolds number \f$Re_p\f$ is defined as: \f$Re_p=\beta\parallel\mathbf{u^b-u^a}\parallel d_{eff}/\nu^b\f$, where \f$\nu^b\f$ stands for the fluid kinematic viscosity. This drag model can be chosen by the keyword ``GidaspowSchillerNaumann'' in the file *constant/interfacialProperties* and it is especially well adapted for dealing with suspended particles. For situations in which the fluid flow inside the porous sediment bed has to be accurately solved, other drag models are available in SedFoam-2312. The major issue in developing an Eulerian two-phase flow model is to provide closure laws for turbulence closures and granular stress models. This will be extensively discussed in the following subsections, particularly different modeling options available in SedFoam-2312  are presented.


\subsection fluidstress Fluid phase shear stress
Expand All @@ -78,7 +78,7 @@ and the viscous stress tensor is modeled as:
\f[
r_{ij}^{b} =2\rho^b\beta\nu^{mix} \ S_{ij}^b, \tag{10}
\f]
In SedFoam-2212, several different viscosity or turbulence closures are implemented, and these models can be selected according to specific flow conditions ranging from laminar to turbulent flows. The mixture viscosity can be selected in combination with a granular rheology model for the granular stresses (see section \ref granularRheo). For the turbulent eddy viscosity, modified turbulence closures are implemented for sediment transport applications.
In SedFoam-2312, several different viscosity or turbulence closures are implemented, and these models can be selected according to specific flow conditions ranging from laminar to turbulent flows. The mixture viscosity can be selected in combination with a granular rheology model for the granular stresses (see section \ref granularRheo). For the turbulent eddy viscosity, modified turbulence closures are implemented for sediment transport applications.


\subsection particleStress Particle phase stress
Expand All @@ -103,13 +103,13 @@ Fr\frac{(\alpha-\alpha_{min}^{Fric})^{\eta_0}}{(\alpha_{max}-\alpha)^{\eta_1}},

where \f$\alpha_{min}^{Fric}=0.57\f$, \f$\alpha_{max}=0.635\f$ for spheres and \f$Fr\f$, \f$\eta_0\f$ and \f$\eta_1\f$ are empirical coefficients. Following Cheng et al.(2017), the values are set to: \f$Fr=0.05, \eta_0=3\f$ and \f$\eta_1=5\f$. Again, these coefficients can be reset in file *constant/kineticTheoryProperties* or  *constant/granularRheologyProperties* by specifying the keywords and values.

In modern sediment transport modeling framework, the two major threads of modeling approach for shear-induced/collisional particle normal stress and shear stress are the kinetic theory of granular flows and the dense granular flow rheology. They are implemented in this version of SedFoam-2212 (see subsections \ref subkinetic and \ref granularRheo), respectively. As a result of different closures for particle normal stresses \f$p^a\f$, the closure for the total particle shear stress \f$\tilde{\tau}^a_{ij}\f$ also varies, and they are described in the next two subsections.
In modern sediment transport modeling framework, the two major threads of modeling approach for shear-induced/collisional particle normal stress and shear stress are the kinetic theory of granular flows and the dense granular flow rheology. They are implemented in this version of SedFoam-2312 (see subsections \ref subkinetic and \ref granularRheo), respectively. As a result of different closures for particle normal stresses \f$p^a\f$, the closure for the total particle shear stress \f$\tilde{\tau}^a_{ij}\f$ also varies, and they are described in the next two subsections.



\subsubsection granularRheo  Dense granular rheology

Concerning the shear-induced contribution to the particle pressure, two different expressions can be adopted depending on the flow regime. Depending on the local Stokes and particulate Reynolds numbers, the regime of the granular flow rheology can change from free fall or grain inertia regime to viscous and turbulent regimes (Andreotti et al., 2013), and the definition of the controlling parameter ‘\f$I\f$’ are different accordingly. In SedFoam-2212, the grain inertia and viscous regimes have been implemented and can be selected using the keywords `MuI' and `MuIv' respectively. Following  the work of Boyer et al. (2011), the shear-induced pressure under the viscous regime can be written as:
Concerning the shear-induced contribution to the particle pressure, two different expressions can be adopted depending on the flow regime. Depending on the local Stokes and particulate Reynolds numbers, the regime of the granular flow rheology can change from free fall or grain inertia regime to viscous and turbulent regimes (Andreotti et al., 2013), and the definition of the controlling parameter ‘\f$I\f$’ are different accordingly. In SedFoam-2312, the grain inertia and viscous regimes have been implemented and can be selected using the keywords `MuI' and `MuIv' respectively. Following  the work of Boyer et al. (2011), the shear-induced pressure under the viscous regime can be written as:



Expand Down
Loading

0 comments on commit 21171eb

Please sign in to comment.