style: fix many style issues (#647)

* style: switch private fields to properties
* style: add missing scope for attributes
* style: switch private fields to properties
* style: fix order of modifiers
* style: add static modifier when not using any fields/properties
* style: add missing Assert.Multiple
* style: improve consistency in naming conventions when using private fields
* style: remove pragma where not needed anymore
* style: [WIP] improve exception messages for ArgumentException
* style: use compound assignment
* style: remove unused parameter
* style: prefer TryGetValue call
* style: prefer Any than Count
* style: mark as static if not using any field/property
* style: decrease exposition of some methods
* style: improve exception messages
* style: naming rules violations
* style: remove unused internal constructors
* style: add style enforcement

DubUrl.Adomd/Discovery/NativeMethods.cs

@@ -28,14 +28,15 @@ internal static extern bool EnumThreadWindows(int dwThreadId, EnumThreadDelegate
 
 #pragma warning disable CA1838 // Avoid 'StringBuilder' parameters for P/Invokes
         [DllImport("User32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
-        internal unsafe static extern int SendMessageTimeout(
+        internal static extern unsafe int SendMessageTimeout(
             IntPtr hWnd,
             uint uMsg,
             uint wParam,
             StringBuilder? lParam,
             uint fuFlags,
             uint uTimeout,
             void* lpdwResult);
+#pragma warning restore CA1838 // Avoid 'StringBuilder' parameters for P/Invokes
 
         [DllImport("user32.dll", CharSet = CharSet.Unicode)]
         internal static extern IntPtr SendMessage(IntPtr hWnd, uint Msg, int wParam,
@@ -44,14 +45,9 @@ internal static extern IntPtr SendMessage(IntPtr hWnd, uint Msg, int wParam,
         [DllImport("user32.dll", SetLastError = true, CharSet = CharSet.Auto)]
         internal static extern int GetWindowTextLength(IntPtr hWnd);
 
+#pragma warning disable CA1838 // Avoid 'StringBuilder' parameters for P/Invokes
         [DllImport("User32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
         internal static extern long GetWindowText(IntPtr hwnd, StringBuilder lpString, long cch);
 #pragma warning restore CA1838 // Avoid 'StringBuilder' parameters for P/Invokes
-
-        public const int WM_COPYDATA = 0x4A;
-
-        [DllImport("user32", CharSet = CharSet.Auto)]
-        public extern static int SendMessage(IntPtr hwnd, int wMsg,
-            int wParam, ref COPYDATASTRUCT lParam);
     }
 }

DubUrl.Adomd/Discovery/TcpDiscoverer.cs

@@ -25,13 +25,14 @@ public static TcpTable GetExtendedTcpTable(bool sorted)
                     if (UnmanagedTcpDiscoverer.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, UnmanagedTcpDiscoverer.AfInet, UnmanagedTcpDiscoverer.TcpTableType.OwnerPidAll, 0) == 0)
                     {
                         var table = (UnmanagedTcpDiscoverer.TcpTable)(Marshal.PtrToStructure(tcpTable, typeof(UnmanagedTcpDiscoverer.TcpTable)) ?? throw new NullReferenceException());
-
+#pragma warning disable CA2020
                         var rowPtr = (IntPtr)((long)tcpTable + Marshal.SizeOf(table.length));
                         for (int i = 0; i < table.length; ++i)
                         {
                             tcpRows.Add(new TcpRow((UnmanagedTcpDiscoverer.TcpRow)(Marshal.PtrToStructure(rowPtr, typeof(UnmanagedTcpDiscoverer.TcpRow)) ?? throw new NullReferenceException())));
                             rowPtr = (IntPtr)((long)rowPtr + Marshal.SizeOf(typeof(UnmanagedTcpDiscoverer.TcpRow)));
                         }
+#pragma warning restore CA2020
                     }
                 }
                 finally
@@ -58,12 +59,13 @@ public static Dictionary<int, TcpRow> GetExtendedTcpDictionary()
                     tcpTable = Marshal.AllocHGlobal(tcpTableLength);
                     if (UnmanagedTcpDiscoverer.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, UnmanagedTcpDiscoverer.AfInet, UnmanagedTcpDiscoverer.TcpTableType.OwnerPidAll, 0) == 0)
                     {
-                        UnmanagedTcpDiscoverer.TcpTable table = (UnmanagedTcpDiscoverer.TcpTable)(Marshal.PtrToStructure(tcpTable, typeof(UnmanagedTcpDiscoverer.TcpTable)) ?? throw new NullReferenceException());
-
+                        var table = (UnmanagedTcpDiscoverer.TcpTable)(Marshal.PtrToStructure(tcpTable, typeof(UnmanagedTcpDiscoverer.TcpTable)) ?? throw new NullReferenceException());
+#pragma warning disable CA2020
                         var rowPtr = (IntPtr)((long)tcpTable + Marshal.SizeOf(table.length));
+#pragma warning restore CA2020
                         for (int i = 0; i < table.length; ++i)
                         {
-                            TcpRow row = new TcpRow((UnmanagedTcpDiscoverer.TcpRow)(Marshal.PtrToStructure(rowPtr, typeof(UnmanagedTcpDiscoverer.TcpRow)) ?? throw new NullReferenceException()));
+                            var row = new TcpRow((UnmanagedTcpDiscoverer.TcpRow)(Marshal.PtrToStructure(rowPtr, typeof(UnmanagedTcpDiscoverer.TcpRow)) ?? throw new NullReferenceException()));
                             // HACK: only add first row that is in a Listening state
                             if (row.State == TcpState.Listen)
                             {

DubUrl.Adomd/Discovery/WindowTitle.cs

@@ -49,9 +49,7 @@ public static string GetWindowTitleTimeout(int procId, uint timeout)
                     // ignore it and skip to the next one in the collection
                     title = GetWindowTextTimeout(handle, timeout);
                 }
-#pragma warning disable CA1031
-                catch (Exception)
-#pragma warning restore CA1031
+                catch 
                 {
                     title = string.Empty;
                 }
@@ -94,13 +92,11 @@ private static string GetCaptionOfWindow(IntPtr hwnd)
                 if (!string.IsNullOrWhiteSpace(windowText.ToString()))
                     caption = windowText.ToString();
             }
-#pragma warning disable CA1031
             catch (Exception ex)
-#pragma warning restore CA1031
             {
                 caption = ex.Message;
             }
             return caption;
         }
     }
-}
+}

DubUrl.Adomd/Querying/DaxRenderer.cs

@@ -27,7 +27,7 @@ public string Render(object? obj, string format)
                 return obj?.ToString() ?? "<empty>";
 
             if (format.ToLowerInvariant() == "identity")
-                return Identity.Format(obj ?? throw new ArgumentNullException());
+                return Identity.Format(obj ?? throw new ArgumentNullException(nameof(obj)));
 
             if (format.ToLowerInvariant() == "value")
             {
@@ -36,10 +36,10 @@ public string Render(object? obj, string format)
                 if (Value.Values.TryGetValue(obj.GetType(), out var formatter))
                     return formatter.Format(obj);
                 else
-                    throw new ArgumentException();
+                    throw new ArgumentException($"No value formatter was found for the type '{obj.GetType().Name}'", nameof(format));
             }
             else
-                throw new ArgumentException($"The format '{format}' is not a supported format. Only 'identifty' and 'value' are supported.");
+                throw new ArgumentException($"The format '{format}' is not a supported format. Only 'identifty' and 'value' are supported.", nameof(format));
         }
     }
 }

DubUrl.Adomd/Rewriting/PowerBiDesktopRewriter.cs

@@ -18,7 +18,7 @@ internal class PowerBiDesktopRewriter : ConnectionStringRewriter
         protected internal const string SERVER_KEYWORD = "Data Source";
 
         protected internal const string DEFAULT_LOCALHOST = "localhost";
-        protected internal readonly static string[] VALID_HOSTS =
+        protected internal static readonly string[] VALID_HOSTS =
             new[] { "127.0.0.1", ".", string.Empty, DEFAULT_LOCALHOST };
 
         public PowerBiDesktopRewriter(DbConnectionStringBuilder csb)
@@ -58,7 +58,7 @@ public int GetPortFromSegments(string[] segments)
             {
                 var pbiName = segments.Length == 1
                                 ? segments[0]
-                                : throw new InvalidConnectionUrlException("A single segment is expected when using a Power BI Desktop connection-url");
+                                : throw new ArgumentOutOfRangeException(nameof(segments));
 
                 var processes = Discoverer.GetPowerBiProcesses();
                 if (processes.Any(x => x.Name == pbiName))
@@ -67,4 +67,4 @@ public int GetPortFromSegments(string[] segments)
             }
         }
     }
-}
+}

DubUrl.Core/ConnectionUrl.cs

@@ -18,8 +18,8 @@ namespace DubUrl
     public class ConnectionUrl
     {
         private record ParseResult(string ConnectionString, UrlInfo UrlInfo, IDialect Dialect, IConnectivity Connectivity, IParametrizer Parametrizer) { }
-        private ParseResult? _result;
-        private ParseResult Result { get => _result ??= ParseDetail(); }
+        private ParseResult? result;
+        private ParseResult Result { get => result ??= ParseDetail(); }
         private SchemeMapperBuilder SchemeMapperBuilder { get; }
         private IMapper? Mapper { get; set; }
         private IParser Parser { get; }

DubUrl.Core/Extensions/ProviderInvariantNameAttribute.cs

@@ -6,6 +6,7 @@
 
 namespace DubUrl.Extensions
 {
+    [AttributeUsage(AttributeTargets.Class)]
     public class ProviderInvariantNameAttribute : Attribute
     {
         public string Value { get; set; }

DubUrl.Core/Locating/BaseLocatorFactory.cs

@@ -17,18 +17,18 @@ public abstract class BaseLocatorFactory
         public void AddAlias(string alias, string original)
         {
             if (Schemes.ContainsKey(alias))
-                throw new ArgumentException();
+                throw new ArgumentException($"There is already a scheme registered with the alias '{alias}'. You cannot add a second scheme with the same alias.", nameof(alias));
 
             if (!Schemes.ContainsKey(original))
-                throw new ArgumentException();
+                throw new ArgumentException($"There is no scheme registered with the alias '{original}'. You cannot add an alias if the scheme is not already registered.", nameof(original));
 
             Schemes.Add(alias, Schemes[original]);
         }
 
         protected void AddElement(string alias, Type locator)
         {
             if (Schemes.ContainsKey(alias))
-                throw new ArgumentException();
+                throw new ArgumentException($"There is already a locator registered for the alias '{alias}'. You cannot register two locators with the same alias", nameof(alias));
 
             Schemes.Add(alias, locator);
         }

DubUrl.Core/Locating/OdbcDriver/BaseDriverLocator.cs

@@ -44,6 +44,6 @@ protected internal static int GetOptionPosition<T>(Type optionType)
         =>
             (typeof(T).GetCustomAttributes(typeof(LocatorAttribute), false).FirstOrDefault() as LocatorAttribute)
             ?.Options.ToList().IndexOf(optionType)
-            ?? throw new ArgumentOutOfRangeException();
+            ?? throw new ArgumentOutOfRangeException(optionType.Name);
     }
 }

DubUrl.Core/Locating/OdbcDriver/DriverLister.cs

@@ -15,16 +15,14 @@ public virtual string[] List()
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
                 var drivers = new List<string>();
-#pragma warning disable CA1416 // Validate platform compatibility
                 drivers.AddRange(ListFromRegistry(Registry.LocalMachine));
                 drivers.AddRange(ListFromRegistry(Registry.CurrentUser));
-#pragma warning restore CA1416 // Validate platform compatibility
                 return drivers.ToArray();
             }
             return Array.Empty<string>();
         }
 
-        private List<string> ListFromRegistry(RegistryKey registryKey)
+        private static List<string> ListFromRegistry(RegistryKey registryKey)
         {
 #pragma warning disable CA1416 // Validate platform compatibility
             var drivers = new List<string>();
@@ -41,4 +39,4 @@ private List<string> ListFromRegistry(RegistryKey registryKey)
             return drivers;
         }
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/DriverLocatorFactory.cs

@@ -33,7 +33,7 @@ public virtual IDriverLocator Instantiate(string scheme)
         public virtual IDriverLocator Instantiate(string scheme, IDictionary<Type, object> options)
         {
             if (!Schemes.ContainsKey(scheme))
-                throw new ArgumentException();
+                throw new ArgumentException($"There is no scheme registered with the alias '{scheme}'.", nameof(scheme));
 
             var driverLocatorType = Schemes[scheme];
             var ctors = driverLocatorType.GetConstructors(BindingFlags.Instance | BindingFlags.Public);
@@ -50,4 +50,4 @@ public virtual IDriverLocator Instantiate(string scheme, IDictionary<Type, objec
 
         public void AddDriver(string alias, Type locator) => AddElement(alias, locator);
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/DrillDriverLocator.cs

@@ -24,7 +24,7 @@ public DrillDriverRegex()
             { }
         }
 
-        private readonly List<string> Candidates = new();
+        private List<string> Candidates { get; } = new();
         internal EncodingOption Encoding { get; }
 
         public DrillDriverLocator()
@@ -40,4 +40,4 @@ protected override List<string> RankCandidates()
 
 
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/DuckdbDriverLocator.cs

@@ -25,7 +25,7 @@ public DuckdbDriverRegex()
                 })
             { }
         }
-        private readonly List<string> Candidates = new();
+        private List<string> Candidates { get; } = new();
         public DuckdbDriverLocator()
             : base(GetRegexPattern<DuckdbDriverLocator>()) { }
         internal DuckdbDriverLocator(DriverLister driverLister)

DubUrl.Core/Locating/OdbcDriver/Implementation/MariaDbDriverLocator.cs

@@ -28,7 +28,7 @@ public MariaDbDriverRegex()
             { }
         }
 
-        private readonly Dictionary<string, decimal> Candidates = new();
+        private Dictionary<string, decimal> Candidates { get; } = new();
         internal EncodingOption Encoding { get; }
 
         public MariaDbDriverLocator()
@@ -52,4 +52,4 @@ protected override List<string> RankCandidates()
 
 
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/MsExcelDriverLocator.cs

@@ -24,7 +24,7 @@ public MsExcelDriverRegex()
                 })
             { }
         }
-        private readonly List<string> Candidates = new();
+        private List<string> Candidates { get; } = new();
 
         public MsExcelDriverLocator()
             : base(GetRegexPattern<MsExcelDriverLocator>()) { }
@@ -38,4 +38,4 @@ protected override void AddCandidate(string driver, string[] matches)
         protected override List<string> RankCandidates()
             => Candidates;
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/MssqlDriverLocator.cs

@@ -28,7 +28,7 @@ public MssqlDriverRegex()
             { }
         }
 
-        private readonly Dictionary<string, int> Candidates = new();
+        private Dictionary<string, int> Candidates { get; } = new();
         public MssqlDriverLocator()
             : base(GetRegexPattern<MssqlDriverLocator>()) { }
         internal MssqlDriverLocator(DriverLister driverLister)
@@ -40,4 +40,4 @@ protected override void AddCandidate(string driver, string[] matches)
         protected override List<string> RankCandidates()
             => Candidates.OrderByDescending(x => x.Value).Select(x => x.Key).ToList();
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/MySqlConnectorDriverLocator.cs

@@ -30,7 +30,7 @@ public MySqlConnectorDriverRegex()
             { }
         }
 
-        private readonly Dictionary<string, decimal> Candidates = new();
+        private Dictionary<string, decimal> Candidates { get; } = new();
         internal EncodingOption Encoding { get; }
 
         public MySqlConnectorDriverLocator()
@@ -63,4 +63,4 @@ protected override void AddCandidate(string driver, string[] matches)
         protected override List<string> RankCandidates()
             => Candidates.OrderByDescending(x => x.Value).Select(x => x.Key).ToList();
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/PostgresqlDriverLocator.cs

@@ -29,7 +29,7 @@ public PostgresqlDriverRegex()
 
         private record struct CandidateInfo(string Driver, EncodingOption Encoding, ArchitectureOption Architecture);
 
-        private readonly List<CandidateInfo> Candidates = new();
+        private List<CandidateInfo> Candidates { get; } = new();
         internal EncodingOption Encoding { get; }
         internal ArchitectureOption Architecture { get; }
 

DubUrl.Core/Locating/OdbcDriver/Implementation/TextDriverLocator.cs

@@ -24,7 +24,7 @@ public TextDriverRegex()
                 })
             { }
         }
-        private readonly List<string> Candidates = new();
+        private List<string> Candidates { get; } = new();
 
         public TextDriverLocator()
             : base(GetRegexPattern<TextDriverLocator>()) { }
@@ -38,4 +38,4 @@ protected override void AddCandidate(string driver, string[] matches)
         protected override List<string> RankCandidates()
             => Candidates;
     }
-}
+}

DubUrl.Core/Locating/OdbcDriver/Implementation/TrinoDriverLocator.cs

@@ -26,7 +26,7 @@ public TrinoDriverRegex()
             { }
         }
 
-        private readonly List<string> Candidates = new();
+        private List<string> Candidates { get; } = new();
         public TrinoDriverLocator()
             : base(GetRegexPattern<TrinoDriverLocator>()) { }
         internal TrinoDriverLocator(DriverLister driverLister)
@@ -38,4 +38,4 @@ protected override void AddCandidate(string driver, string[] matches)
         protected override List<string> RankCandidates()
             => Candidates.OrderByDescending(x => x).ToList();
     }
-}
+}

DubUrl.Core/Locating/RegexUtils/StringBuilderExtensions.cs

@@ -8,13 +8,13 @@ namespace DubUrl.Locating.RegexUtils
 {
     internal static class StringBuilderExtensions
     {
-        private static char[] EscapedChars = new[] { '[', ']', '(', ')', '{', '}', '*', '+', '?', '|', '^', '$', '.', '\\', '-' };
+        private static readonly char[] escapedChars = new[] { '[', ']', '(', ')', '{', '}', '*', '+', '?', '|', '^', '$', '.', '\\', '-' };
 
         public static StringBuilder AppendEscaped(this StringBuilder stringBuilder, string text)
         {
             foreach (var c in text.ToArray())
             {
-                if (EscapedChars.Contains(c))
+                if (escapedChars.Contains(c))
                     stringBuilder.Append('\\');
                 stringBuilder.Append(c);
             }

DubUrl.Core/Mapping/AlternativeMapperAttribute.cs

@@ -9,7 +9,7 @@
 namespace DubUrl.Mapping
 {
     [AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
-    sealed public class AlternativeMapperAttribute<T, P> : AlternativeMapperAttribute 
+    public sealed class AlternativeMapperAttribute<T, P> : AlternativeMapperAttribute 
         where T : IDatabase
         where P : IParametrizer
     {

DubUrl.Core/Mapping/BrandAttribute.cs

@@ -7,6 +7,7 @@
 
 namespace DubUrl.Mapping
 {
+    [AttributeUsage(AttributeTargets.Class)]
     public class BrandAttribute : Attribute
     {
         public const string DefaultMainColor = "#333333";