Skip to content

Commit

Permalink
test: activate two tests previously ignored for firebird (#1069)
Browse files Browse the repository at this point in the history
* fix: explicitly set field names to prevent casing issues
* fix: use renderer conversion to prevent conversion issue
  • Loading branch information
Seddryck authored Jul 16, 2024
1 parent 073388b commit 8e26113
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 11 deletions.
2 changes: 2 additions & 0 deletions DubUrl.QA/DubUrl.QA.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<None Remove="SelectFirstCustomer.singlestore.sql" />
<None Remove="SelectWhereCustomers.cratedb.sql.st" />
<None Remove="SelectWhereCustomers.dax.st" />
<None Remove="SelectWhereCustomers.firebird.sql.st" />
<None Remove="SelectYoungestCustomers.cratedb.sql" />
<None Remove="SelectYoungestCustomers.dax" />
<None Remove="SelectYoungestCustomers.singlestore.sql" />
Expand All @@ -39,6 +40,7 @@
<EmbeddedResource Include="SelectFirstCustomer.cratedb.sql" />
<EmbeddedResource Include="SelectFirstCustomer.singlestore.sql" />
<EmbeddedResource Include="SelectFirstCustomer.msdax" />
<EmbeddedResource Include="SelectWhereCustomers.firebird.sql.st" />
<EmbeddedResource Include="SelectWhereCustomers.cratedb.sql.st" />
<EmbeddedResource Include="SelectWhereCustomers.dax.st" />

Expand Down
10 changes: 1 addition & 9 deletions DubUrl.QA/FirebirdSQL/AdoProviderFirebirdSQL.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,4 @@ public override void QueryCustomerWithPositionalParameter()
[Test]
public override void QueryCustomerWithDapper()
=> QueryCustomerWithDapper("select * from Customer");

[Test]
public override void QueryTwoYoungestCustomersWithRepositoryFactory()
=> Assert.Ignore("Not investigated why, but not working");

[Test]
public override void QueryCustomerWithWhereClause()
=> Assert.Ignore("Not investigated why, but not working");
}
}
8 changes: 8 additions & 0 deletions DubUrl.QA/SelectWhereCustomers.firebird.sql.st
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
select
$fields:{field | $field$ AS "$field$"}; separator="
, "$
from
Customer
where
$clauses:{clause | $clause.Field$ $clause.Operator$ $clause.Value;format="value"$}; separator="
and "$
6 changes: 4 additions & 2 deletions DubUrl.QA/SelectYoungestCustomers.firebird.sql
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
select first 2
CustomerId, FullName, BirthDate
CustomerId as "CustomerId"
, FullName as "FullName"
, BirthDate as "BirthDate"
from
Customer
order by
BirthDate desc
BirthDate desc

0 comments on commit 8e26113

Please sign in to comment.