Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keeper to default coordinators list #680

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ben-kaufman
Copy link

Description

Add Bitcoin Keeper to the list of coordinators enabled by default.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:

Add Bitcoin Keeper to the list of coordinators enabled by default.
@fedebuyito
Copy link
Contributor

Pytested on python3.10/12 on KALI Linux Live: Ok.

Tested the workflow and it does what it states. Only a minimal doubt: was the order of the coordinator for some reason?

image
image

Original views:
image
image

Regards. -

@ben-kaufman
Copy link
Author

Thanks for the review!

I changed the order to maintain the alphabetical order of the list, does that make sense?

@fedebuyito
Copy link
Contributor

You are welcome. Yes, that makes sense. However, keeping the original order in which options were added could be a good reason (in terms of UX) too. I haven't been on the project long enough to know or determine that. Maybe @jdlcdl or @easyuxd could give us their focus.

Regards. -

@newtonick newtonick added this to the 0.9.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants