Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…

…tyling
Sefaria · Dec 15, 2024 · c802b75 · c802b75
2 parents 62350fd + 7466742
commit c802b75
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/static/js/ReaderPanel.jsx b/static/js/ReaderPanel.jsx
@@ -685,6 +685,7 @@ class ReaderPanel extends Component {
       );
     }
     if (this.state.mode === "Sheet") {
+      console.log(this.props)
       menu = <Sheet
           adjustHighlightedAndVisible={this.adjustSheetHighlightedAndVisible}
           panelPosition ={this.props.panelPosition}

diff --git a/static/js/sheets/Sheet.jsx b/static/js/sheets/Sheet.jsx
@@ -69,7 +69,7 @@ class Sheet extends Component {
 
       else if (Sefaria.isRef(path.slice(1))) {
         e.preventDefault();
-        window.open(target.href);
+        Sefaria.util.openInNewTab(target.href);
       }
     }
   }

diff --git a/static/js/sheets/SheetContentSidebar.jsx b/static/js/sheets/SheetContentSidebar.jsx
@@ -22,12 +22,12 @@ const SheetContentSidebar = ({authorImage, authorStatement, authorUrl, toggleSig
                 name={authorStatement}
             />
             {authorName}
-            {!loading && <SheetProfileInfo profile={profile}/>}
+            {!loading && <SheetProfileInfo profile={profile} toggleSignUpModal={toggleSignUpModal}/>}
             {<PartOfCollections collections={collections}/>}
     </div>;
 }
 
-const SheetProfileInfo = ({profile}) => {
+const SheetProfileInfo = ({profile, toggleSignUpModal}) => {
     const profileFollowers = <div className="profileFollowers">
                                              <InterfaceText>{String(profile.followers.length)}</InterfaceText>&nbsp;
                                              <InterfaceText>followers</InterfaceText>
@@ -38,7 +38,8 @@ const SheetProfileInfo = ({profile}) => {
              {Sefaria._uid !== profile.id && <FollowButton
                                                 large={true}
                                                 uid={profile.id}
-                                                following={Sefaria.following.indexOf(profile.id) > -1}/>
+                                                following={Sefaria.following.indexOf(profile.id) > -1}
+                                                toggleSignUpModal={toggleSignUpModal}/>
              }
            </span>;
 }