Api v3 #1543
Merged
Api v3 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nck methods to it.
…ry and more simple.
…ibutes rather than another list.
If `other` Ref is a whole book, and `self` begins anywhere after first segment, `contains` is trivially false and we can avoid expensive code.
fix: Performance improvement of Ref.contains
…r stripping notes and html), or wrap_all_entities (for adding html for ref links and topic links).
… in the api rather than actualLanguage which is just the language ISO code.
edamboritz
approved these changes
Dec 18, 2023
| try: | ||
| self.oref = Ref.instantiate_ref_with_legacy_parse_fallback(kwargs['tref']) | ||
| except Exception as e: | ||
| return jsonResponse({'error': getattr(e, 'message', str(e))}, status=400) |
There was a problem hiding this comment.
This should be a 404, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new branch for only api