User Dropdown for Logged out Library #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e flexibility upon implementation
edamboritz
approved these changes
Sep 4, 2024
| padding: 10px 2px; | ||
| } | ||
|
|
||
| .englishLanguageButton::after { |
There was a problem hiding this comment.
I think you can actually make this a bit more general, not needing to create a special class for the enlish link
There was a problem hiding this comment.
Good thinking!
I did this because of annoying spacing issues with r/l padding on English vs Hebrew buttons. Is that OK in this case? Happy to show you if it's clearer that way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dropdown menu for modularized library, specifically for logged out users.
Code Changes
The following changes were made to the files below:
static/css/s2.css- Some minor padding shifts, adding styling for the language toggle with a pseudo-class for the dot separator.static/icons/logged_out.svg- The new logged out iconstatic/js/common/DropdownMenu.jsx- Improving the generic<DropdownMenu />component to enhance reusability (i.e. making the icon for the dropdown customizable, and control over whether or not to open links in new tabs).static/js/Header.jsx- Adding the new logged out component (<LoggedOutMenu />), implementing the shifts to the generic component mentioned above in the module switcher.