Language selection playwright tests #2057
Open
+194
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sefaria/Sefaria-Playwright-Tests#18 TODO: Decide if we want to test for default translation title.
Issue noted for Hebrew sources - no default translation is selected.
Also allowing default translation validations to be skipped for Hebrew language source texts
Issue: Tests time out on assertions looking for text in the wrong language Solution: Clearing the cookies resets the cookie-setting process and allows language cookies to be refreshed for each context.
ci: allow integration tests to be run by hand
ci: don't skip on manual workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here