Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of Strapi banners on static pages #2161

Merged

Conversation

relyks
Copy link
Contributor

@relyks relyks commented Dec 9, 2024

This is a temporary fix for the display of Strapi banners to fix the spacing in the header when the banners are closed. The setContainerMode code for adjusting the class on <body> used to work, but is currently not working. That code will need to be refactored in the future.

@relyks relyks requested a review from edamboritz December 9, 2024 19:33
@relyks relyks self-assigned this Dec 9, 2024
Copy link
Contributor

@edamboritz edamboritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make sure we fix the actual root cause of this.

Did we validate that this doesn't negatively affect any other areas?

@edamboritz edamboritz merged commit 587c797 into master Dec 10, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants