Feature/sc 27327/source click should open in new tab2 #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etContentMetaDataBox
…-27328/options-popover-component
…-27328/options-popover-component
…-27327/source-click-should-open-in-new-tab
…-27328/options-popover-component
…-27328/options-popover-component
…-27327/source-click-should-open-in-new-tab
…-27328/options-popover-component
…e/sc-27825/add-to-sheet
…-27328/options-popover-component
…e/sc-27825/add-to-sheet
…re/sc-27825/add-to-sheet2
Feature/sc 27826/styling
…c-27327/source-click-should-open-in-new-tab2
…into feature/sc-27328/options-popover-component2
…re/sc-27825/add-to-sheet2
…r-component2 Feature/sc 27328/options popover component2
stevekaplan123
changed the base branch from
feature/sc-27331/new-sidebar-component2
to
sheets-viewer-final
…-should-open-in-new-tab2
…into feature/sc-27825/add-to-sheet2
yitzhakc
requested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a small change whereby when a user clicks on a ref in a sheet, it will open in a new tab instead of opening a new panel.
Code Changes
optionswas unused so I removed thatonCitationClickwas no longer necessary to call so I replaced it with a call towindow.openNotes
This should be merged before #2163