-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 27825/add to sheet2 #2179
Merged
stevekaplan123
merged 112 commits into
feature/sc-27327/source-click-should-open-in-new-tab2
from
feature/sc-27825/add-to-sheet2
Jan 21, 2025
Merged
Feature/sc 27825/add to sheet2 #2179
stevekaplan123
merged 112 commits into
feature/sc-27327/source-click-should-open-in-new-tab2
from
feature/sc-27825/add-to-sheet2
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
This reverts commit f3d7ed5.
…s so I can style it appropriately
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…e/sc-27825/add-to-sheet
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
…re/sc-27825/add-to-sheet2
Feature/sc 27826/styling
yitzhakc
requested changes
Jan 8, 2025
…re/sc-27825/add-to-sheet2
stevekaplan123
changed the base branch from
feature/sc-27328/options-popover-component2
to
feature/sc-27327/source-click-should-open-in-new-tab2
January 13, 2025 13:14
…into feature/sc-27825/add-to-sheet2
yitzhakc
requested changes
Jan 19, 2025
yitzhakc
approved these changes
Jan 20, 2025
stevekaplan123
merged commit Jan 21, 2025
fac73db
into
feature/sc-27327/source-click-should-open-in-new-tab2
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature this PR implements is that it attaches an "Add to Sheet" button to every segment of the sheet. The button is hidden, but when the user clicks on the segment, the "Add to Sheet" button appears. After the user clicks the "Add to Sheet" button, a modal appears allowing the user to select which of the user's sheets to add the segment to.
Code Changes