Skip to content

Conversation

FMassin
Copy link
Contributor

@FMassin FMassin commented Feb 5, 2025

Here's another contribution to the tooltip!

Changes:

  • Added all pick comments (format "ID : value") to the tooltip.
  • Ensured comments are loaded before assigning the pick.

Implementation:

  • PickerMarker: Iterates over commentCount(), appending comments to the tooltip.
  • PickerView: Calls loadComments(pick) before setting it in marker.

Example:

Screenshot 2025-02-05 at 19 34 47

Test version:

scolv
Framework: 7.0.0 Development
API version: 17.0.0
Data schema version: 0.13
GIT HEAD: 836f199e
Compiler: c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Build system: Linux 5.15.0-117-generic
OS: Ubuntu 22.04.5 LTS / Linux

@cla-bot cla-bot bot added the cla-signed The CLA has been signed by all contributors label Feb 5, 2025
@FMassin
Copy link
Contributor Author

FMassin commented Feb 7, 2025

@gempa-jabe : Making further test with v0.12 database I realised I get segmentation fault. I hope it is due to the outdated data model. Could you please try with a up-to-date database?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed by all contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant