build: Install dependencies only in Tox environments (#1785)

.github/workflows/tests.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Lint
         run: make lint
 
-  mlserver:
+  test-mlserver:
     strategy:
       fail-fast: false
       matrix:
@@ -95,20 +95,16 @@ jobs:
         uses: snok/install-poetry@v1
         with:
           virtualenvs-create: false
-      - name: Install Dependencies
-        run: |
-          if [[ ${{ runner.os == 'macOS' }} ]]; then
-            source ./hack/activate-libomp-macos.sh
-          fi
-          poetry install --sync --only dev
+      - name: Install dependencies
+        run: poetry install --only test
       - name: Test
         run: |
           if [[ ${{ runner.os == 'macOS' }} ]]; then
             source ./hack/activate-libomp-macos.sh
           fi
-          tox -e mlserver
+          poetry run tox -e mlserver
 
-  runtimes:
+  test-runtimes:
     strategy:
       fail-fast: false
       matrix:
@@ -152,21 +148,17 @@ jobs:
         uses: snok/install-poetry@v1
         with:
           virtualenvs-create: false
-      - name: Install Dependencies
-        run: |
-          if [[ ${{ runner.os == 'macOS' }} ]]; then
-            source ./hack/activate-libomp-macos.sh
-          fi
-          poetry install --sync --only dev
+      - name: Install dependencies
+        run: poetry install --only test
       - name: Test
         run: |
           if [[ ${{ runner.os == 'macOS' }} ]]; then
             source ./hack/activate-libomp-macos.sh
           fi
-          tox -c ./runtimes/${{ matrix.tox-environment }}
+          poetry run tox -c ./runtimes/${{ matrix.tox-environment }}
 
   # Ensure that having all the runtimes installed together works
-  all-runtimes:
+  test-all-runtimes:
     if: github.event_name == 'push'
     strategy:
       fail-fast: false
@@ -209,15 +201,11 @@ jobs:
         uses: snok/install-poetry@v1
         with:
           virtualenvs-create: false
-      - name: Install Dependencies
-        run: |
-          if [[ ${{ runner.os == 'macOS' }} ]]; then
-            source ./hack/activate-libomp-macos.sh
-          fi
-          poetry install --sync --only dev
+      - name: Install dependencies
+        run: poetry install --only test
       - name: Test
         run: |
           if [[ ${{ runner.os == 'macOS' }} ]]; then
             source ./hack/activate-libomp-macos.sh
           fi
-          tox -e all-runtimes
+          poetry run tox -e all-runtimes

Makefile

@@ -5,6 +5,14 @@ IMAGE_NAME := seldonio/mlserver
 .PHONY: install-dev _generate generate run build \
 	push-test push test lint fmt version clean licenses
 
+.PHONY: bootstrap-test
+bootstrap-test:
+	for _runtime in ./runtimes/*; \
+	do \
+		echo "Copying Tox configuration to $$_runtime..."; \
+		cp tox.runtime.ini $$_runtime/tox.ini; \
+	done
+
 install-dev:
 	poetry install --sync --with all-runtimes --with all-runtimes-dev
 

pyproject.toml

@@ -76,6 +76,9 @@ opentelemetry-instrumentation-grpc = ">=0.43b0"
 opentelemetry-exporter-otlp-proto-grpc = "^1.22.0"
 pytest-lazy-fixture = "^0.6.3"
 
+[tool.poetry.group.test.dependencies]
+tox = "4.14.2"
+
 [tool.poetry.group.dev.dependencies]
 datamodel-code-generator = "0.25.5"
 grpcio-tools = "1.48.2"

runtimes/alibi-detect/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/alibi-explain/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/catboost/tox.ini

@@ -4,8 +4,8 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
-    python -m pytest {posargs} \
+    python -m pytest {posargs} -n auto \
         {toxinidir}/tests

runtimes/huggingface/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/lightgbm/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/mlflow/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/mllib/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/sklearn/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

runtimes/xgboost/tox.ini

@@ -4,7 +4,7 @@ isolated_build = true
 [testenv]
 allowlist_externals = poetry
 commands_pre =
-    poetry install --sync --no-root 
+    poetry install --sync --no-root
     poetry install -C {toxinidir}/../../
 commands =
     python -m pytest {posargs} -n auto \

tox.runtime.ini

@@ -0,0 +1,11 @@
+[tox]
+isolated_build = true
+
+[testenv]
+allowlist_externals = poetry
+commands_pre =
+    poetry install --sync --no-root
+    poetry install -C {toxinidir}/../../
+commands =
+    python -m pytest {posargs} -n auto \
+        {toxinidir}/tests