Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed macos kafka CI #1807

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Fixed macos kafka CI #1807

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f29303d
Set cp-kafka to 7.6.1
RobertSamoilescu Jun 14, 2024
2393312
Included more configs.
RobertSamoilescu Jun 14, 2024
112bb7c
Included extra_hosts
RobertSamoilescu Jun 14, 2024
3a9c937
SSH into workflow
RobertSamoilescu Jun 17, 2024
dd4227c
Reverted kafka conftest to master.
RobertSamoilescu Jun 17, 2024
8556341
Update tox to run kafka separately.
RobertSamoilescu Jun 17, 2024
061d61d
Removed tmate
RobertSamoilescu Jun 17, 2024
a190253
Checking tests.
RobertSamoilescu Jun 17, 2024
426a742
Test all runtimes.
RobertSamoilescu Jun 17, 2024
f3f5f88
Test failing test
RobertSamoilescu Jun 17, 2024
964ef2e
Reverted tests and enable mlserver macos tests
RobertSamoilescu Jun 17, 2024
57e2de9
Reverted test to master.
RobertSamoilescu Jun 17, 2024
79eef51
Included clarification comments.
RobertSamoilescu Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ commands_pre =
poetry install --sync --no-root
commands =
python -m pytest {posargs} -n auto \
{toxinidir}/tests
{toxinidir}/tests --ignore={toxinidir}/tests/kafka
# kafka tests are failinig for macos when running in parallel
# with the entire test suite. So, we run them separately.
python -m pytest {posargs} -n auto \
{toxinidir}/tests/kafka
set_env =
GITHUB_SERVER_URL = {env:GITHUB_SERVER_URL:https\://github.com}
GITHUB_REPOSITORY = {env:GITHUB_REPOSITORY:SeldonIO/MLServer}
Expand All @@ -41,7 +45,12 @@ commands =
{toxinidir}/runtimes/mllib \
{toxinidir}/runtimes/lightgbm \
{toxinidir}/runtimes/mlflow \
{toxinidir}/runtimes/huggingface
{toxinidir}/runtimes/huggingface \
--ignore={toxinidir}/tests/kafka
# kafka tests are failinig for macos when running in parallel
# with the entire test suite. So, we run them separately.
python -m pytest {posargs} -n auto \
{toxinidir}/tests/kafka
set_env =
GITHUB_SERVER_URL = {env:GITHUB_SERVER_URL:https\://github.com}
GITHUB_REPOSITORY = {env:GITHUB_REPOSITORY:SeldonIO/MLServer}
Expand Down
Loading