Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ page #606

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Add FAQ page #606

merged 5 commits into from
Mar 17, 2022

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Mar 11, 2022

Addresses #448.

Please provide feedback on the coverage of questions considered as well as the phrasing of the answers. One thing I'm not too sure about (without running experiments) are the two scenarios for getting anchor explanations.

@ascillitoe
Copy link
Contributor

One minor comment about the logging, but in general I think this looks great. I think the FAQ references the appropriate existing docs really nicely.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #606 (4a18325) into master (c2fbd55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files          77       77           
  Lines       10520    10520           
=======================================
  Hits         8633     8633           
  Misses       1887     1887           

doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
doc/source/overview/faq.md Outdated Show resolved Hide resolved
@jklaise
Copy link
Contributor Author

jklaise commented Mar 15, 2022

I've reworked the questions to be third level section headers so it's easier to link to a specific FAQ.

Copy link
Collaborator

@mauicv mauicv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add some questions covering stuff we don't yet support? For instance mixed data types or data frames?

Otherwise looks good to me.


There can be many reasons why the method does not work. For code exceptions it is a good idea to check the following:
- Read the [docstrings](../api/modules.rst) of the method, paying close attention to the [type hints](https://docs.python.org/3/library/typing.html) as most errors are due to misformatted input arguments.
- Check that your model signature (its type and expected inputs/outputs) are in the right format. For further details refer to [White-box and black-box models](../overview/white_box_black_box.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this point covers this issue. It might be useful to have this as a separate Question that includes the specific description and solution given in that issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, another specific formatting issue I've seen people ask about is including the batch_size when passing to AnchorImage. i.e. instead of (28, 28, 3) they pass (1, 28, 28, 3).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, will include.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another separate question about different data types, linking to the docs about writing wrapper functions and the Github issue. I've also added a point under general troubleshooting about checking expected input types for explain methods, with particular care to single instances vs batches.

@jklaise jklaise merged commit 24e13ce into SeldonIO:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants