-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQ page #606
Add FAQ page #606
Conversation
One minor comment about the logging, but in general I think this looks great. I think the FAQ references the appropriate existing docs really nicely. |
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 82.06% 82.06%
=======================================
Files 77 77
Lines 10520 10520
=======================================
Hits 8633 8633
Misses 1887 1887 |
I've reworked the questions to be third level section headers so it's easier to link to a specific FAQ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add some questions covering stuff we don't yet support? For instance mixed data types or data frames?
Otherwise looks good to me.
doc/source/overview/faq.md
Outdated
|
||
There can be many reasons why the method does not work. For code exceptions it is a good idea to check the following: | ||
- Read the [docstrings](../api/modules.rst) of the method, paying close attention to the [type hints](https://docs.python.org/3/library/typing.html) as most errors are due to misformatted input arguments. | ||
- Check that your model signature (its type and expected inputs/outputs) are in the right format. For further details refer to [White-box and black-box models](../overview/white_box_black_box.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this point covers this issue. It might be useful to have this as a separate Question that includes the specific description and solution given in that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, another specific formatting issue I've seen people ask about is including the batch_size
when passing to AnchorImage
. i.e. instead of (28, 28, 3)
they pass (1, 28, 28, 3)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, will include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added another separate question about different data types, linking to the docs about writing wrapper functions and the Github issue. I've also added a point under general troubleshooting about checking expected input types for explain
methods, with particular care to single instances vs batches.
Addresses #448.
Please provide feedback on the coverage of questions considered as well as the phrasing of the answers. One thing I'm not too sure about (without running experiments) are the two scenarios for getting anchor explanations.