Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] added a note about deprecation of seldon and tensorflow protocol #6182

Merged
merged 15 commits into from
Jan 17, 2025
Merged

[Update] added a note about deprecation of seldon and tensorflow protocol #6182

merged 15 commits into from
Jan 17, 2025

Conversation

Rajakavitha1
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I have note deleted any existing content that explains about Seldon or TensorFlow protocol. Only added a note in the related sections about transitioning to OIP.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Rajakavitha1
❌ Rakavitha Kodhandapani

Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Rajakavitha1 Rajakavitha1 requested a review from sakoush December 31, 2024 08:07
@Rajakavitha1 Rajakavitha1 marked this pull request as ready for review January 2, 2025 10:26
matthewlowdon
matthewlowdon requested changes Jan 4, 2025
View reviewed changes
Copy link
Member

@matthewlowdon matthewlowdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, remove references to Seldon Protocol and Tensorflow Protocol no longer being supported in Core 1.

@Rajakavitha1
Copy link
Contributor Author

As discussed, remove references to Seldon Protocol and Tensorflow Protocol no longer being supported in Core 1.

Hi @matthewlowdon. I rephrased the note. Please take a look.

@Rajakavitha1 Rajakavitha1 requested a review from tchellam January 6, 2025 12:12
@Rajakavitha1
Copy link
Contributor Author

Hi @matthewlowdon and @tchellam I updated the note to include MLServer. Please review.

matthewlowdon
matthewlowdon requested changes Jan 15, 2025
View reviewed changes
doc/source/analytics/explainers.md Outdated Show resolved Hide resolved
doc/source/graph/protocols.md
@@ -87,3 +61,36 @@ In particular,
| [MLFLOW_SERVER](../servers/mlflow.md) | ✅ | [Seldon MLServer](https://github.com/seldonio/mlserver) |

You can try out the `v2` in [this example notebook](../examples/protocol_examples.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps refer to OIP in addition to V2..? (V2 is the old name for OIP)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated the changes suggested.

doc/source/graph/protocols.md Outdated Show resolved Hide resolved
examples/models/lightgbm_custom_server/iris.ipynb Outdated Show resolved Hide resolved
matthewlowdon
matthewlowdon approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@matthewlowdon matthewlowdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@Rajakavitha1 Rajakavitha1 merged commit 801ddf4 into master Jan 17, 2025
8 of 13 checks passed
@Rajakavitha1 Rajakavitha1 deleted the protocol-rajie branch January 17, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlowdon matthewlowdon matthewlowdon approved these changes

@sakoush sakoush Awaiting requested review from sakoush

@tchellam tchellam Awaiting requested review from tchellam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rajakavitha1 @CLAassistant @matthewlowdon