feat(scheduler): Scale down server logic #6246
Draft
+363
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
force-pushed
the
INFRA-1234/server_scale_down_policy
branch
from
2393553 to
3ed62cd
Compare
sakoush
force-pushed
the
INFRA-1234/server_scale_down_policy
branch
from
3ebc37f to
a9145c8
Compare
sakoush
commented
Feb 11, 2025
| return | ||
| } | ||
|
|
||
| if event.UpdateContext == coordinator.SERVER_SCALE { |
There was a problem hiding this comment.
@driev this is the current proposed location to consume server scale (up / down) events and decide on whether actually to change server replicas. Open to suggestions if there are better places for this logic to be defined.
There was a problem hiding this comment.
For example SchedulerServer could be extended with a ServerScaler utility where the logic of scaling up and down could be defined. This is perhaps something we can consider as a follow up PR after we get scale up / down done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: