-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] fix sdist publish instructions #11375
Conversation
It appears that only wheels are being published to pypi, this should fix the publishing procedure to include sdists. Signed-off-by: James Hilliard <[email protected]>
As described in the issue you referenced, our issue is that Bazel is not properly creating the sdist in the first place. We can't publish what isn't getting built. We probably should pull the "publishing" instructions from the README entirely because that really isn't relevant to users. |
I hit one bug which should be fixed by #647, is that the issue you are referring to? |
The issue with publishing is that pypi is expecting a |
@jameshilliard thanks for digging into this! |
Should be fixed in #11379. |
I'll merge this now, thanks! It's already in our releasing documents, which we manage here: https://github.com/SeleniumHQ/selenium/wiki/Releasing-Selenium |
It appears that only wheels are being published to pypi, this should fix the publishing procedure to include sdists.
Description
Update publish procedure to include sdists.
Motivation and Context
Sdists on pypi are missing as reported in #9917
Types of changes
Checklist