Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] fix sdist publish instructions #11375

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

jameshilliard
Copy link
Contributor

It appears that only wheels are being published to pypi, this should fix the publishing procedure to include sdists.

Description

Update publish procedure to include sdists.

Motivation and Context

Sdists on pypi are missing as reported in #9917

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [N/A] I have added tests to cover my changes.
  • [N/A] All new and existing tests passed.

It appears that only wheels are being published to pypi, this should
fix the publishing procedure to include sdists.

Signed-off-by: James Hilliard <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@titusfortner
Copy link
Member

As described in the issue you referenced, our issue is that Bazel is not properly creating the sdist in the first place. We can't publish what isn't getting built. We probably should pull the "publishing" instructions from the README entirely because that really isn't relevant to users.

@jameshilliard
Copy link
Contributor Author

As described in the issue you referenced, our issue is that Bazel is not properly creating the sdist in the first place. We can't publish what isn't getting built.

I hit one bug which should be fixed by #647, is that the issue you are referring to?

@AutomatedTester
Copy link
Member

The issue with publishing is that pypi is expecting a PKG_INFO which we're not generating. I haven't had time to do it but we could probably copy the implementation from py_wheel and create a new rule that maybe we can upstream to rules_python

@titusfortner
Copy link
Member

@jameshilliard thanks for digging into this!

@jameshilliard
Copy link
Contributor Author

The issue with publishing is that pypi is expecting a PKG_INFO which we're not generating.

Should be fixed in #11379.

@titusfortner titusfortner reopened this Dec 13, 2022
@titusfortner
Copy link
Member

I'll merge this now, thanks!

It's already in our releasing documents, which we manage here: https://github.com/SeleniumHQ/selenium/wiki/Releasing-Selenium

@titusfortner titusfortner merged commit 29e1cf6 into SeleniumHQ:trunk Dec 13, 2022
@jameshilliard jameshilliard deleted the publish-sdist branch December 13, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants