Skip to content

[deploy site] added may 2025 event details #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented May 7, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

added may 2025 event details

Motivation and Context

added may 2025 event details

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Updated announcement banner for May 2025 event details

  • Enabled the announcement banner display in site configuration


Changes walkthrough 📝

Relevant files
Enhancement
announcement-banner.html
Update event date and link in announcement banner               

website_and_docs/layouts/partials/announcement-banner.html

  • Changed event date in banner from April 25th to May 21st, 2025
  • Updated LinkedIn event link to new May 2025 event
  • +2/-2     
    Configuration changes
    hugo.toml
    Enable announcement banner in site configuration                 

    website_and_docs/hugo.toml

    • Set announcement_banner flag to true to enable banner display
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented May 7, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit a15243d

    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix inconsistent banner configuration

    The banner_flag is set to false while announcement_banner is set to true, which
    may cause inconsistent banner display. Consider setting both flags to true to
    ensure the announcement banner appears correctly.

    website_and_docs/hugo.toml [166-168]

     # Enable announcement banner below navbar (Go to announcement-banner.html to change the message)
    -banner_flag = false
    +banner_flag = true
     announcement_banner = true
    • Apply / Chat
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical inconsistency where banner_flag is set to false while announcement_banner is set to true. This could prevent the banner from displaying properly despite the PR's intent to enable it. Setting both flags to true ensures the announcement banner functions as expected.

    High
    • More

    @pallavigitwork pallavigitwork merged commit 0ab2c95 into SeleniumHQ:trunk May 7, 2025
    3 checks passed
    selenium-ci added a commit that referenced this pull request May 7, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant