Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that dimmer.settings.closable is boolean #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eykanal
Copy link

@eykanal eykanal commented Jan 28, 2021

The documentation simply states that closable has a default of auto but doesn't state what other values it can take; I had to check the code to see that it's actually a boolean with logic to account for an auto flag. This change updates the docs to reflect this more clearly.

The documentation simply states that `closable` has a default of `auto` but doesn't state what other values it can take; I had to [check the code](https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/modules/dimmer.js#L364) to see that it's actually a boolean with logic to account for an `auto` flag. This change updates the docs to reflect this more clearly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant