Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra semicolon #7089

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

LucienLeMagicien
Copy link
Contributor

@LucienLeMagicien LucienLeMagicien commented Sep 22, 2022

Webpack v5's CSS loader fails when seeing this double semicolon. The error looks something like:

 Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
TypeError: Cannot read property 'get' of undefined
    at /var/www/node_modules/webpack/lib/asset/AssetModulesPlugin.js:212:52
    [...]
error  in data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAwBgT1MvM[...]
Module build failed: UnhandledSchemeError: Reading from "data:application/x-font-ttf;charset=utf-8;;base64,AAEAAAAOAIAAAwBgT1MvM[...]" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "data:" URIs.

As @jlukic says in this comment, this should be the place to fix this.
The contribution guide says to merge against next, but that branch is 32 commits behind so I'm not too sure. Please feel free to adapt.

If this ends up not being merged, or if it does not trigger the automated commits and release, I suppose the other way to fix this would be in the css parser used by webpack?
Otherwise, workarounds can be found on the issues linked in the commit, namely:

This would close #7073 once the updated css is published.

@jlukic
Copy link
Member

jlukic commented Oct 5, 2022

I've gone ahead and merged this, will release to npm most likely this weekend.

@jlukic jlukic merged commit 9f59052 into Semantic-Org:master Oct 5, 2022
@jlukic
Copy link
Member

jlukic commented Oct 6, 2022

Think resolved in 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error using semantic-ui-css to create-react-app
2 participants